Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8434] Add test cases for org.apache.rocketmq.common.action #8435

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

TeFuirnever
Copy link
Contributor

Which Issue(s) This PR Fixes

[Enhancement] Add more test coverage for Add test cases for org.apache.rocketmq.common.action

Fixes #8434

Brief Description

Add more test coverage for Add test cases for org.apache.rocketmq.common.action.

  • org/apache/rocketmq/common/action/Action.java
  • org/apache/rocketmq/common/action/RocketMQAction.java

How Did You Test This Change?

run test case successfull.
image

image

TeFuirnever and others added 4 commits July 21, 2024 15:49
add test case for AclConfig in commom module
Fixes apache#8417

Brief Description
add test case for AclConfig in commom module by using tongyi tools.

How Did You Test This Change?
run test case successfull.
[ISSUE apache#8417]add some test cases for org.apache.rocketmq.common.AclConfig apache#8417
…elop

# Conflicts:
#	common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java
@TeFuirnever
Copy link
Contributor Author

for soc in #8262 .

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.52%. Comparing base (6fb455a) to head (e8ed433).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8435      +/-   ##
=============================================
- Coverage      45.54%   45.52%   -0.02%     
+ Complexity     11031    11025       -6     
=============================================
  Files           1274     1274              
  Lines          88997    88997              
  Branches       11440    11440              
=============================================
- Hits           40532    40517      -15     
- Misses         43427    43429       +2     
- Partials        5038     5051      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShannonDing ShannonDing added the soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on label Jul 24, 2024
@ShannonDing ShannonDing changed the title [ISSUE apache#8434] Add more test coverage for Add test cases for org.apache.rocketmq.common.action [ISSUE #8343] Add test cases for org.apache.rocketmq.common.action Jul 24, 2024
@TeFuirnever TeFuirnever changed the title [ISSUE #8343] Add test cases for org.apache.rocketmq.common.action [ISSUE #8434] Add test cases for org.apache.rocketmq.common.action Jul 24, 2024
@ShannonDing ShannonDing merged commit 59c8609 into apache:develop Jul 25, 2024
10 checks passed
Qoozm pushed a commit to Qoozm/rocketmq that referenced this pull request Jul 26, 2024
…ion (apache#8435)

* Which Issue(s) This PR Fixes
add test case for AclConfig in commom module
Fixes apache#8417

Brief Description
add test case for AclConfig in commom module by using tongyi tools.

How Did You Test This Change?
run test case successfull.

* [ISSUE apache#8434] Add more test coverage for Add test cases for org.apache.rocketmq.common.action
@TeFuirnever TeFuirnever deleted the add-tests-for-action branch July 26, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add test cases for org.apache.rocketmq.common.action
3 participants