[RIP-70-3]Extract adaptive lock mechanism #8663
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8663 +/- ##
=============================================
- Coverage 47.51% 47.36% -0.16%
+ Complexity 11591 11578 -13
=============================================
Files 1282 1285 +3
Lines 89848 89979 +131
Branches 11557 11579 +22
=============================================
- Hits 42692 42617 -75
- Misses 41931 42109 +178
- Partials 5225 5253 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # store/src/main/java/org/apache/rocketmq/store/lock/AdaptiveLockImpl.java # store/src/main/java/org/apache/rocketmq/store/lock/CollisionRetreatLock.java
GenerousMan
reviewed
Sep 26, 2024
Comment on lines
97
to
114
| if (this.adaptiveLock instanceof CollisionRetreatLock) { | ||
| CollisionRetreatLock lock = (CollisionRetreatLock) this.adaptiveLock; | ||
| int base = Math.min(200 + tps / 200, 500); | ||
| if (lock.getNumberOfRetreat(slot) * base >= tps) { | ||
| if (lock.isAdapt()) { | ||
| lock.adapt(true); | ||
| } else { | ||
| this.tpsSwapCriticalPoint = tps; | ||
| needSwap = true; | ||
| } | ||
| } else if (lock.getNumberOfRetreat(slot) * base * 3 / 2 <= tps) { | ||
| lock.adapt(false); | ||
| } | ||
| lock.setNumberOfRetreat(slot, 0); | ||
| } else { | ||
| if (tps <= this.tpsSwapCriticalPoint * 4 / 5) { | ||
| needSwap = true; | ||
| } |
There was a problem hiding this comment.
Too many magic numbers, it should be optimized.
GenerousMan
reviewed
Sep 26, 2024
| import java.util.concurrent.atomic.AtomicBoolean; | ||
| import java.util.concurrent.atomic.AtomicInteger; | ||
|
|
||
| public class CollisionRetreatLock implements AdaptiveBackOffLock { |
There was a problem hiding this comment.
What is RetreatLock? Is it a misspelling of reentrant lock?
GenerousMan
reviewed
Sep 26, 2024
| private final List<AtomicInteger> numberOfRetreat; | ||
|
|
||
| public CollisionRetreatLock() { | ||
| this.initOptimalDegree = 1000; |
There was a problem hiding this comment.
You'd better make these numbers as constants, like OPTIMAL_DEGREE = 1000, MAX_OPTIMAL_DEGREE = 10000
added 2 commits
September 26, 2024 19:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8442
Brief Description
How Did You Test This Change?
Test document ：https://shimo.im/docs/ZzkLMQ4RwwUa87AQ/