Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISUUE #8762] Fix dLedger lock granularity issue causing LMQ message loss #8763

Closed
wants to merge 2 commits into from

Conversation

bxfjb
Copy link
Contributor

@bxfjb bxfjb commented Sep 27, 2024

Which Issue(s) This PR Fixes

Fixes #8762

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 12.50000% with 35 lines in your changes missing coverage. Please review.

Project coverage is 47.30%. Comparing base (daf3d1a) to head (dd99891).

Files with missing lines Patch % Lines
...pache/rocketmq/store/queue/MultiDispatchUtils.java 3.57% 27 Missing ⚠️
...pache/rocketmq/store/dledger/DLedgerCommitLog.java 33.33% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8763      +/-   ##
=============================================
- Coverage      47.51%   47.30%   -0.21%     
+ Complexity     11589    11548      -41     
=============================================
  Files           1282     1282              
  Lines          89848    89888      +40     
  Branches       11557    11568      +11     
=============================================
- Hits           42689    42522     -167     
- Misses         41932    42118     +186     
- Partials        5227     5248      +21     
Flag Coverage Δ
47.30% <12.50%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bxfjb bxfjb closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] DLedger lock granularity issue causing LMQ message loss
2 participants