Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8772] Remove lock mq step in broadcasting mode rebalancing #8774

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

redlsz
Copy link
Contributor

@redlsz redlsz commented Sep 29, 2024

Which Issue(s) This PR Fixes

Fixes #8772

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.37%. Comparing base (551c8c3) to head (f3f7ea0).

Files with missing lines Patch % Lines
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8774      +/-   ##
=============================================
+ Coverage      47.32%   47.37%   +0.04%     
- Complexity     11547    11558      +11     
=============================================
  Files           1282     1282              
  Lines          89864    89864              
  Branches       11563    11563              
=============================================
+ Hits           42530    42570      +40     
+ Misses         42076    42039      -37     
+ Partials        5258     5255       -3     
Flag Coverage Δ
47.37% <50.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhimins lizhimins merged commit 2956f6d into apache:develop Oct 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Remove lock mq step in broadcasting mode rebalancing
5 participants