[ISSUE #8852] Add more test coverage for ClientMetadata #8853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8853 +/- ##
=============================================
+ Coverage 47.40% 47.42% +0.02%
- Complexity 11654 11659 +5
=============================================
Files 1294 1294
Lines 90424 90424
Branches 11627 11627
=============================================
+ Hits 42863 42885 +22
+ Misses 42288 42248 -40
- Partials 5273 5291 +18 ☔ View full report in Codecov by Sentry. |
RongtongJin
reviewed
Oct 23, 2024
| public void testGetBrokerNameFromMessageQueue() { | ||
| MessageQueue mq = new MessageQueue(defaultTopic, defaultBroker, 0); | ||
| topicEndPointsTable.put(defaultTopic, new ConcurrentHashMap<>()); | ||
| topicEndPointsTable.get(defaultTopic).put(mq, defaultBroker); |
There was a problem hiding this comment.
It would be better not to use defaultBroker, so it can be distinguished from testGetBrokerNameFrommessageQueueNotFound test method
There was a problem hiding this comment.
Hi @RongtongJin , changes are complete, please review, thank you.
RongtongJin
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8852 .