Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8892] Add test cases to config manager v2 #8873

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

lizhanhui
Copy link
Contributor

Which Issue(s) This PR Fixes

to #8892

Brief Description

Add unit test cases to ConfigManagerV2

How Did You Test This Change?

@lizhanhui lizhanhui changed the title Test config manager v2 [ISSUE #8892] Add test cases to config manager v2 Oct 29, 2024
Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.55%. Comparing base (ecb45bb) to head (879b41b).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8873      +/-   ##
=============================================
+ Coverage      47.19%   47.55%   +0.36%     
- Complexity     11676    11734      +58     
=============================================
  Files           1304     1304              
  Lines          90984    90989       +5     
  Branches       11668    11668              
=============================================
+ Hits           42936    43273     +337     
+ Misses         42765    42375     -390     
- Partials        5283     5341      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhanhui lizhanhui merged commit dd62ed0 into apache:develop Oct 29, 2024
11 checks passed
@lizhanhui lizhanhui deleted the test-config-manager-v2 branch October 29, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants