[ISSUE #8829] Keep data version while reload and XXXConfigManagerV2 turns off sync #8891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e fdatasync on write proves to be too expensive, turn it off Signed-off-by: Li Zhanhui <[email protected]>
tianliuliu
reviewed
Nov 5, 2024
broker/src/main/java/org/apache/rocketmq/broker/config/v2/SubscriptionGroupManagerV2.java
Show resolved
Hide resolved
broker/src/main/java/org/apache/rocketmq/broker/config/v2/TopicConfigManagerV2.java
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8891 +/- ##
=============================================
- Coverage 47.71% 47.55% -0.17%
+ Complexity 11763 11734 -29
=============================================
Files 1304 1304
Lines 91051 91051
Branches 11675 11675
=============================================
- Hits 43448 43300 -148
- Misses 42274 42409 +135
- Partials 5329 5342 +13 ☔ View full report in Codecov by Sentry. |
RongtongJin
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor changes are included:
1, no need to update data version while reload;
2, config-storage fdatasync on write proves to be too expensive, turn it off
Which Issue(s) This PR Fixes
To #8829
Brief Description
How Did You Test This Change?