Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8917]Topic route return none permission message queues for gRPC client #8919

Merged

Conversation

dingshuangxi888
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8917

Brief Description

When the queue lacks permission, return queues to allow the client to upload a heartbeat for gRPC Topic route interface.

How Did You Test This Change?

… to upload a heartbeat for gRPC Topic route interface.
…he client to upload a heartbeat for gRPC Topic route interface.
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.56%. Comparing base (2bbc852) to head (b54926c).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../org/apache/rocketmq/common/constant/PermName.java 0.00% 1 Missing ⚠️
...he/rocketmq/proxy/grpc/v2/route/RouteActivity.java 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8919      +/-   ##
=============================================
- Coverage      47.66%   47.56%   -0.10%     
+ Complexity     11758    11736      -22     
=============================================
  Files           1304     1304              
  Lines          91058    91057       -1     
  Branches       11677    11674       -3     
=============================================
- Hits           43401    43314      -87     
- Misses         42316    42397      +81     
- Partials        5341     5346       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lollipopjin lollipopjin merged commit 87b97f2 into apache:develop Nov 14, 2024
11 checks passed
@dingshuangxi888 dingshuangxi888 deleted the feature/grpc_return_noperm_route branch November 14, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Topic route return none permission message queues for gRPC client
3 participants