BUG FIX: set target file size multiplier #1704
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
documentation of
targetFileSizeBase
andtargetFileSizeMultiplier
is located here (texted copied below)Before the change
samza/samza-kv-rocksdb/src/main/java/org/apache/samza/storage/kv/RocksDbOptionsHelper.java
Lines 178 to 184 in f9c3241
Behavior:
ROCKSDB_COMPACTION_TARGET_FILE_SIZE_BASE
is configured, the value ofROCKSDB_COMPACTION_TARGET_FILE_SIZE_BASE
will be set as the target file size base.ROCKSDB_COMPACTION_TARGET_FILE_SIZE_MULTIPLIER
is configured, the value ofROCKSDB_COMPACTION_TARGET_FILE_SIZE_MULTIPLIER
will be set as the target file size base (it's wrong, and the file size multiplier should be set instead).After the change
Behavior:
ROCKSDB_COMPACTION_TARGET_FILE_SIZE_BASE
is configured, the value ofROCKSDB_COMPACTION_TARGET_FILE_SIZE_BASE
will be set as the target file size base.ROCKSDB_COMPACTION_TARGET_FILE_SIZE_MULTIPLIER
is configured, the value ofROCKSDB_COMPACTION_TARGET_FILE_SIZE_MULTIPLIER
will be set as the file size multiplier.Tests