Add Default Configuration for RocksDB MaxManifestFileSize #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yehaolan
commented
Aug 20, 2024
| @@ -321,7 +321,8 @@ These properties define Samza's storage mechanism for efficient [stateful stream | |||
| |stores.**_store-name_**.<br>rocksdb.keep.log.file.num|2|The number of RocksDB LOG files (including rotated LOG.old.* files) to keep.| | |||
| |stores.**_store-name_**.<br>rocksdb.metrics.list|(none)|A list of [RocksDB properties](https://github.com/facebook/rocksdb/blob/master/include/rocksdb/db.h#L409) to expose as metrics (gauges).| | |||
| |stores.**_store-name_**.<br>rocksdb.delete.obsolete.files.period.micros|21600000000|This property specifies the period in microseconds to delete obsolete files regardless of files removed during compaction. Allowed range is up to 9223372036854775807.| | |||
| |stores.**_store-name_**.<br>rocksdb.max.manifest.file.size|18446744073709551615|This property specifies the maximum size of the MANIFEST data file, after which it is rotated. Default value is also the maximum, making it practically unlimited: only one manifest file is used.| | |||
There was a problem hiding this comment.
The number was outdated, and it should be 1024^3 which is 1073741824
- The RocksDB version for Samza was upgraded from
5.7.3to6.5.3at 0189b5d - In
5.7.3, themax_manifest_file_sizedefaults to uint64 max which is18446744073709551615(https://github.com/facebook/rocksdb/blob/v5.7.3/include/rocksdb/options.h#L547) - In
6.5.3, themax_manifest_file_sizedefaults to 1GB which is1024*1024*1024(https://github.com/facebook/rocksdb/blob/v6.5.3/include/rocksdb/options.h#L623)
ajothomas
requested changes
Aug 21, 2024
samza-core/src/main/java/org/apache/samza/config/StorageConfig.java
Outdated
Show resolved
Hide resolved
ajothomas
reviewed
Aug 22, 2024
samza-core/src/main/java/org/apache/samza/config/StorageConfig.java
Outdated
Show resolved
Hide resolved
dxichen
requested changes
Aug 22, 2024
docs/learn/documentation/versioned/jobs/samza-configurations.md
Outdated
Show resolved
Hide resolved
|
|
||
| static final String DEFAULT_ROCKSDB_MAX_MANIFEST_FILE_SIZE = | ||
| STORE_PREFIX + DEFAULT_STORE_NAME + ".rocksdb.max.manifest.file.size"; |
There was a problem hiding this comment.
for the default config, lets not follow the same format as the config with named stores in case of default table name collision
samza-core/src/main/java/org/apache/samza/config/StorageConfig.java
Outdated
Show resolved
Hide resolved
dxichen
requested changes
Aug 22, 2024
samza-kv-rocksdb/src/main/java/org/apache/samza/storage/kv/RocksDbKeyValueReader.java
Outdated
Show resolved
Hide resolved
dxichen
approved these changes
Aug 26, 2024
ajothomas
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
stores.default.rocksdb.max.manifest.file.sizein Samza allowing to set the default manifest file size for all stores.stores.default.rocksdb.max.manifest.file.sizeis1G(1024*1024*1024), which is the default value in RocksDB v7.8.3 that is currently used by Samza https://github.com/facebook/rocksdb/blob/v7.8.3/include/rocksdb/options.h#L786Tests
TestStorageConfig.java