[Improve] Add custom job id arg in client #6943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
approved these changes
Jun 5, 2024
lightzhao
approved these changes
Jun 6, 2024
wuchunfu
approved these changes
Jun 6, 2024
|
Thanks all, merged. |
3 tasks
liunaijie
reviewed
Jun 13, 2024
| new JobContext(isStartWithSavePoint ? jobId : jobClient.getNewJobId())); | ||
| Long finalJobId; | ||
| if (isStartWithSavePoint || jobId != null) { | ||
| finalJobId = jobId; |
There was a problem hiding this comment.
@Hisoka-X hi, i relealize a problem, if user pass same job id with the running jobs, will it has issue?
now i story some status in IMAP by job id. if use same job id, the status maybe impact?
There was a problem hiding this comment.
Yes, the key point is that the ID cannot be repeated, which currently needs to be ensured by the user
3 tasks
chaorongzhi
pushed a commit
to chaorongzhi/seatunnel
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This PR add a new param in
seatunnel.shnamed--set-job-id. User can use this param to fix job id when submit job. Not generate by SeaTunnel. This usage can facilitate third-party integration of SeaTunnel.Does this PR introduce any user-facing change?
no
How was this patch tested?
add new test.
Check list
New License Guide
release-note.