Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Transform-V2] Remove SQL query validation on table name #7020

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

This PR try to remove SQL query validation on table name. Removing this check allows seatunnel web to use the SQL transform normally.

Does this PR introduce any user-facing change?

no

How was this patch tested?

add new test.

Check list

@Hisoka-X
Copy link
Member Author

cc @hailin0 @rewerma

@Hisoka-X Hisoka-X merged commit 9b371cd into apache:dev Jun 20, 2024
4 checks passed
@Hisoka-X Hisoka-X deleted the remove-sql-check-table branch June 20, 2024 11:14
@laixueyong
Copy link

Snipaste_2024-07-05_13-45-02
web使用sql后 对应翻译出来的sql首先没有库名只要表名而且web也是只能填表名 其次sql语句后面结尾\n\n
Snipaste_2024-07-05_13-45-14

@laixueyong
Copy link

报错位置在ZetaSQLEngine这个的validateSQL这个检测方法 大概153行

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants