Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Zeta] Make the default value of classloader-cache-mode is true #7938

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

dailai
Copy link
Contributor

@dailai dailai commented Oct 29, 2024

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@github-actions github-actions bot added the Zeta label Oct 29, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the doc.

@dailai
Copy link
Contributor Author

dailai commented Oct 29, 2024

Please update the doc.

done

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting this configuration true or false will bring different problems, but generally, setting this configuration true is more user-friendly for most users, and it makes the server more stable.

@hailin0 hailin0 merged commit 2f4ca01 into apache:dev Oct 29, 2024
4 of 5 checks passed
@Hisoka-X
Copy link
Member

This change break our thread leak check. We should revert it first.
image

@Hisoka-X
Copy link
Member

This change break our thread leak check. We should revert it first. image

#7940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants