Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] use cari package's NewTask and NewTombstone functions and change db name in mongo model #233

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

robotLJW
Copy link
Member

@robotLJW robotLJW commented Dec 22, 2021

issus: #226
【修改内容】:
1、使用 cari 公共包的 NewTask 和 NewTombstone方法,替换原先的 kie 里面的 func
2、将db为mongo时的dbname由kie修改成servicecomb
【修改原因】:
1、抽取公共部分到第三方库用于使用
2、将mongo的dbname改成servicecomb是因为service-center这边也有task任务,若使用两个 db 这边不太好控制
【影响范围】:无
【自测情况】:不影响测试用例

@robotLJW robotLJW changed the title [feat] use cari package's NewTask and NewTombstone functions and chan… [feat] use cari package's NewTask and NewTombstone functions and change db name in mongo model Dec 22, 2021
@robotLJW robotLJW added the enhancement New feature or request label Dec 22, 2021
@robotLJW robotLJW force-pushed the master branch 3 times, most recently from 70b56b8 to 3e93ff5 Compare December 22, 2021 06:18
little-cui
little-cui previously approved these changes Dec 22, 2021
server/datasource/etcd/kv/kv_dao.go Outdated Show resolved Hide resolved
@little-cui little-cui self-requested a review December 22, 2021 12:35
@little-cui little-cui dismissed their stale review December 22, 2021 12:35

wrong operation

@little-cui little-cui merged commit 5f53fdc into apache:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants