Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support report the index of servicecomb_kie_config_count to prometheus #315

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

tornado-ssy
Copy link
Contributor

No description provided.


type MetricObject struct {
Domain string `yaml:"domain"`
Project string `yaml:"project"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要配置,这些通过环境变量控制即可

"github.com/apache/servicecomb-kie/server/datasource"
)

const ReportInterval = 15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个需要可配置

if m.Project == "" {
m.Project = "default"
}
ReportTicker := time.NewTicker(ReportInterval * time.Second)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

局部变量命名大写开头不规范

@@ -0,0 +1,57 @@
package metric
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是server/metrics包

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants