Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement local file system #341

Merged
merged 11 commits into from
Oct 30, 2023
Merged

Implement local file system #341

merged 11 commits into from
Oct 30, 2023

Conversation

sollhui
Copy link
Contributor

@sollhui sollhui commented Oct 15, 2023 •
edited
Loading

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2023 •
edited
Loading

Codecov Report

Merging #341 (1cd54e3) into main (dbb75ae) will decrease coverage by 0.60%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   38.70%   38.11%   -0.60%     
==========================================
  Files         114      116       +2     
  Lines       12567    12762     +195     
==========================================
  Hits         4864     4864              
- Misses       7225     7420     +195     
  Partials      478      478
Files Coverage Δ
pkg/fs/error.go 0.00% <0.00%> (ø)
pkg/fs/local_file_system.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hanahmily hanahmily added this to the 0.6.0 milestone Oct 18, 2023
@hanahmily hanahmily added the enhancement New feature or request label Oct 18, 2023
hanahmily
hanahmily requested changes Oct 19, 2023
View reviewed changes
pkg/fs/file_system.go Outdated Show resolved Hide resolved
pkg/fs/file_system.go Outdated Show resolved Hide resolved
pkg/fs/file_system.go Outdated Show resolved Hide resolved
pkg/fs/file_system.go Outdated Show resolved Hide resolved
pkg/fs/file_system.go Outdated Show resolved Hide resolved
pkg/fs/local_file_system.go Show resolved Hide resolved
pkg/fs/local_file_system.go Show resolved Hide resolved
pkg/fs/local_file_system.go Outdated Show resolved Hide resolved
pkg/fs/local_file_system_test.go Show resolved Hide resolved
pkg/fs/local_file_system_test.go Outdated Show resolved Hide resolved
@sollhui sollhui changed the title Implement local file system (WIP)Implement local file system Oct 22, 2023
hanahmily
hanahmily requested changes Oct 23, 2023
View reviewed changes
pkg/fs/local_file_system.go Outdated Show resolved Hide resolved
@sollhui sollhui changed the title (WIP)Implement local file system Implement local file system Oct 28, 2023
@hanahmily hanahmily merged commit 0b55f26 into apache:main Oct 30, 2023
14 checks passed
@sollhui sollhui mentioned this pull request Jul 16, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanahmily hanahmily hanahmily approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

[BanyanDB] Implement unify persistence data storage
4 participants
@sollhui @codecov-commenter @hanahmily @wu-sheng