Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark: HTTP2 fix cancel_stream_error #2612

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Benchmark: HTTP2 fix cancel_stream_error #2612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9eba56
Benchmark: HTTP2 fix cancel_stream_error
dsmiley Aug 1, 2024
50e0cee
unlimited
dsmiley Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 0 additions & 52 deletions solr/benchmark/src/java/org/apache/solr/bench/search/SimpleSearch.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,58 +90,6 @@ public void teardownIt() {
}
}

/**
* Under high load http2 client could throw the below exception
*
* <pre>{@code
* org.apache.solr.client.solrj.SolrServerException: IOException occurred when talking to server at: http://127.0.0.1:49436/solr/c1/select?q=id%3A0&wt=javabin&version=2
* at org.apache.solr.client.solrj.impl.Http2SolrClient.request(Http2SolrClient.java:533)
* at org.apache.solr.bench.search.SimpleSearch.query(SimpleSearch.java:89)
* at org.apache.solr.bench.search.jmh_generated.SimpleSearch_query_jmhTest.query_thrpt_jmhStub(SimpleSearch_query_jmhTest.java:275)
* at org.apache.solr.bench.search.jmh_generated.SimpleSearch_query_jmhTest.query_Throughput(SimpleSearch_query_jmhTest.java:127)
* at jdk.internal.reflect.GeneratedMethodAccessor8.invoke(Unknown Source)
* at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
* at java.base/java.lang.reflect.Method.invoke(Method.java:566)
* at org.openjdk.jmh.runner.BenchmarkHandler$BenchmarkTask.call(BenchmarkHandler.java:475)
* at org.openjdk.jmh.runner.BenchmarkHandler$BenchmarkTask.call(BenchmarkHandler.java:458)
* at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
* at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
* at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
* at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
* at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
* at java.base/java.lang.Thread.run(Thread.java:829)
* Caused by: java.io.IOException: cancel_stream_error
* at org.eclipse.jetty.http2.client.http.HttpReceiverOverHTTP2.onReset(HttpReceiverOverHTTP2.java:202)
* at org.eclipse.jetty.http2.client.http.HttpChannelOverHTTP2$Listener.onReset(HttpChannelOverHTTP2.java:206)
* at org.eclipse.jetty.http2.api.Stream$Listener.onReset(Stream.java:271)
* at org.eclipse.jetty.http2.HTTP2Stream.notifyReset(HTTP2Stream.java:853)
* at org.eclipse.jetty.http2.HTTP2Stream.onReset(HTTP2Stream.java:563)
* at org.eclipse.jetty.http2.HTTP2Stream.process(HTTP2Stream.java:392)
* at org.eclipse.jetty.http2.HTTP2Session.onReset(HTTP2Session.java:320)
* at org.eclipse.jetty.http2.parser.Parser$Listener$Wrapper.onReset(Parser.java:367)
* at org.eclipse.jetty.http2.parser.BodyParser.notifyReset(BodyParser.java:139)
* at org.eclipse.jetty.http2.parser.ResetBodyParser.onReset(ResetBodyParser.java:92)
* at org.eclipse.jetty.http2.parser.ResetBodyParser.parse(ResetBodyParser.java:61)
* at org.eclipse.jetty.http2.parser.Parser.parseBody(Parser.java:193)
* at org.eclipse.jetty.http2.parser.Parser.parse(Parser.java:122)
* at org.eclipse.jetty.http2.HTTP2Connection$HTTP2Producer.produce(HTTP2Connection.java:278)
* at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.produceTask(AdaptiveExecutionStrategy.java:450)
* at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.tryProduce(AdaptiveExecutionStrategy.java:243)
* at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.produce(AdaptiveExecutionStrategy.java:194)
* at org.eclipse.jetty.http2.HTTP2Connection.produce(HTTP2Connection.java:208)
* at org.eclipse.jetty.http2.HTTP2Connection.onFillable(HTTP2Connection.java:155)
* at org.eclipse.jetty.http2.HTTP2Connection$FillableCallback.succeeded(HTTP2Connection.java:378)
* at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:100)
* at org.eclipse.jetty.io.SelectableChannelEndPoint$1.run(SelectableChannelEndPoint.java:53)
* at org.eclipse.jetty.util.thread.Invocable.invokeNonBlocking(Invocable.java:151)
* at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.invokeAsNonBlocking(AdaptiveExecutionStrategy.java:433)
* at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.consumeTask(AdaptiveExecutionStrategy.java:375)
* at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.tryProduce(AdaptiveExecutionStrategy.java:272)
* at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.produce(AdaptiveExecutionStrategy.java:194)
* at org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:289)
* ... 3 more
* }</pre>
*/
@Benchmark
public Object query(
BenchState benchState, MiniClusterState.MiniClusterBenchState miniClusterState, Blackhole bh)
Expand Down
2 changes: 2 additions & 0 deletions solr/test-framework/src/java/org/apache/solr/embedded/JettySolrRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
import org.apache.solr.util.configuration.SSLConfigurationsFactory;
import org.eclipse.jetty.alpn.server.ALPNServerConnectionFactory;
import org.eclipse.jetty.http2.HTTP2Cipher;
import org.eclipse.jetty.http2.parser.RateControl;
import org.eclipse.jetty.http2.server.HTTP2CServerConnectionFactory;
import org.eclipse.jetty.http2.server.HTTP2ServerConnectionFactory;
import org.eclipse.jetty.rewrite.handler.RewriteHandler;
Expand Down Expand Up @@ -323,6 +324,7 @@ private void init(int port) {

HTTP2ServerConnectionFactory http2ConnectionFactory =
new HTTP2ServerConnectionFactory(configuration);
http2ConnectionFactory.setRateControlFactory(new RateControl.Factory() {}); // unlimited

ALPNServerConnectionFactory alpn =
new ALPNServerConnectionFactory(
Expand Down