Skip to content

Commit

Permalink
naming.
Browse files Browse the repository at this point in the history
Change-Id: I719078352ab04f3ab096e62fd2b6a1c06bbdffd3
  • Loading branch information
leanken-zz committed Nov 12, 2020
1 parent 36d235a commit 4b161a4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2040,7 +2040,7 @@ case class ElementAt(
""
}

val failOnErrorBranch = if (failOnError) {
val indexOutOfBoundBranch = if (failOnError) {
s"""throw new ArrayIndexOutOfBoundsException(
| "Invalid index: " + $index + ", numElements: " + $eval1.numElements()
|);
Expand All @@ -2052,7 +2052,7 @@ case class ElementAt(
s"""
|int $index = (int) $eval2;
|if ($eval1.numElements() < Math.abs($index)) {
| $failOnErrorBranch
| $indexOutOfBoundBranch
|} else {
| if ($index == 0) {
| throw new ArrayIndexOutOfBoundsException("SQL array indices start at 1");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ case class GetArrayItem(
""
}

val failOnErrorBranch = if (failOnError) {
val indexOutOfBoundBranch = if (failOnError) {
s"""throw new ArrayIndexOutOfBoundsException(
| "Invalid index: " + $index + ", numElements: " + $eval1.numElements()
|);
Expand All @@ -293,7 +293,7 @@ case class GetArrayItem(
s"""
final int $index = (int) $eval2;
if ($index >= $eval1.numElements() || $index < 0) {
$failOnErrorBranch
$indexOutOfBoundBranch
} $nullCheck else {
${ev.value} = ${CodeGenerator.getValue(eval1, dataType, index)};
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ case class Elt(
""".stripMargin
}.mkString)

val failOnErrorBranch = if (failOnError) {
val indexOutOfBoundBranch = if (failOnError) {
s"""
|if (!$indexMatched) {
| throw new ArrayIndexOutOfBoundsException(
Expand All @@ -358,7 +358,7 @@ case class Elt(
|do {
| $codes
|} while (false);
|$failOnErrorBranch
|$indexOutOfBoundBranch
|final ${CodeGenerator.javaType(dataType)} ${ev.value} = $inputVal;
|final boolean ${ev.isNull} = ${ev.value} == null;
""".stripMargin)
Expand Down

0 comments on commit 4b161a4

Please sign in to comment.