Bug fix in generation of sparse vector.

apache · Nov 24, 2015 · 70917f8 · 70917f8
1 parent b5038e8
commit 70917f8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala b/mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala
@@ -134,7 +134,7 @@ object LinearDataGenerator {
 
     val rnd = new Random(seed)
     val rndG = new Random(seed)
-    if (sparsity <= 0.0) {
+    if (sparsity == 0.0) {
       (0 until nPoints).map { _ =>
         val features = Vectors.dense((0 until weights.length).map { i =>
           (rnd.nextDouble() - 0.5) * math.sqrt(12.0 * xVariance(i)) + xMean(i)
@@ -148,7 +148,7 @@ object LinearDataGenerator {
       val sparseRnd = new Random(seed)
       (0 until nPoints).map { _ =>
         val (values, indices) = (0 until weights.length).filter { _ =>
-          sparseRnd.nextDouble() >= sparsity }.map { i =>
+          sparseRnd.nextDouble() <= sparsity }.map { i =>
           ((rnd.nextDouble() - 0.5) * math.sqrt(12.0 * xVariance(i)) + xMean(i), i)
         }.unzip
         val features = Vectors.sparse(weights.length, indices.toArray, values.toArray)