Skip to content

Commit

Permalink
[MINOR][BUILD] Update all checkstyle dtd to use "https://checkstyle.org"
Browse files Browse the repository at this point in the history
## What changes were proposed in this pull request?

Below build failed with Java checkstyle test, but instead of violation it shows FileNotFound on dtd file.
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102751/

Looks like the link of dtd file is dead `http://www.puppycrawl.com/dtds/configuration_1_3.dtd`.

This patch updates the dtd link to "https://checkstyle.org/dtds/" given checkstyle repository also updated the URL path.
checkstyle/checkstyle#5601

## How was this patch tested?

Checked the new links.

Closes #23887 from HeartSaVioR/java-checkstyle-dtd-change-url.

Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]>
Signed-off-by: Marcelo Vanzin <[email protected]>
  • Loading branch information
HeartSaVioR authored and Marcelo Vanzin committed Feb 25, 2019
1 parent a3192d9 commit c5de804
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dev/checkstyle-suppressions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

<!DOCTYPE suppressions PUBLIC
"-//Puppy Crawl//DTD Suppressions 1.1//EN"
"http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
"https://checkstyle.org/dtds/suppressions_1_1.dtd">

<!--
Expand Down
2 changes: 1 addition & 1 deletion dev/checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

<!DOCTYPE module PUBLIC
"-//Puppy Crawl//DTD Check Configuration 1.3//EN"
"http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
"https://checkstyle.org/dtds/configuration_1_3.dtd">

<!--
Expand Down

0 comments on commit c5de804

Please sign in to comment.