-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-12159] [ML] Add user guide section for IndexToString transformer #10166
Conversation
Test build #47245 has finished for PR 10166 at commit
|
It might be useful to also document the different ways "missing" labels can be handled - what are your thoughts? |
Hey @holdenk, thanks for reviewing. Do you mean regarding StringIndexer#setHandleInvalid method? If so, yes that'd be a good addition. However, I'm not sure if I should include it in this jira/pr or create another, input welcome. |
cc @jkbradley |
That is what I was referring to, handling it in a follow up JIRA/PR seems ok too (just since one of the things blocking the original implementation was wanting to have it be user controllable if we allowed people to specify their own maps it seemed like good for that to also make it through to the docs). |
Thanks for the PR; I'll take a look now! |
for more details on the API. | ||
|
||
{% highlight scala %} | ||
import org.apache.spark.ml.feature.{IndexToString, StringIndexer} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind moving these to examples/ and pulling the code snippets into here using the include_example functionality? You can find examples of include_example in this .md file. This makes the examples easier to test & maintain.
Those are my only comments; the examples look good. Btw, it's OK this time, but in general, I'd recommend doing little cleanups in a separate PR. Especially when lots of docs are being merged, it's really easy to hit merge conflicts. Thanks! I'll watch for updates. |
@jkbradley Thanks for reviewing, will take those comments into account. |
That was a spurious test failure; I asked it to retest |
Test build #2184 has finished for PR 10166 at commit
|
|
LGTM except for the Python style issue |
Test build #47361 has finished for PR 10166 at commit
|
Test build #47363 has finished for PR 10166 at commit
|
Merging with master and branch-1.6 Thanks for the PR! |
Documentation regarding the `IndexToString` label transformer with code snippets in Scala/Java/Python. Author: BenFradet <[email protected]> Closes #10166 from BenFradet/SPARK-12159. (cherry picked from commit 06746b3) Signed-off-by: Joseph K. Bradley <[email protected]>
@jkbradley Should I log a jira for completing the user guide on StringIndexer regarding the handling of missing labels @holdenk was talking about? |
If you wouldn't mind, that'd be great, thanks! |
will do |
Documentation regarding the
IndexToString
label transformer with code snippets in Scala/Java/Python.