[SPARK-12195] [SQL] Adding BigDecimal, Date and Timestamp into Encoder #10188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #47309 has finished for PR 10188 at commit
|
| @@ -386,6 +389,20 @@ public void testNestedTupleEncoder() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void testTypeEncoder() { | |||
There was a problem hiding this comment.
Sure. Thank you! Let me change it now.
|
Test build #47310 has finished for PR 10188 at commit
|
|
Test build #47311 has finished for PR 10188 at commit
|
|
LGTM |
|
Thanks, merging to master and 1.6 |
asfgit
pushed a commit
that referenced
this pull request
Dec 8, 2015
This PR is to add three more data types into Encoder, including `BigDecimal`, `Date` and `Timestamp`. marmbrus cloud-fan rxin Could you take a quick look at these three types? Not sure if it can be merged to 1.6. Thank you very much! Author: gatorsmile <[email protected]> Closes #10188 from gatorsmile/dataTypesinEncoder. (cherry picked from commit c0b13d5) Signed-off-by: Michael Armbrust <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add three more data types into Encoder, including
BigDecimal,DateandTimestamp.@marmbrus @cloud-fan @rxin Could you take a quick look at these three types? Not sure if it can be merged to 1.6. Thank you very much!