Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-12201][SQL] add type coercion rule for greatest/least #10196

Closed
wants to merge 1 commit into from

Conversation

cloud-fan
Copy link
Contributor

checked with hive, greatest/least should cast their children to a tightest common type,
i.e. (int, long) => long, (int, string) => error, (decimal(10,5), decimal(5, 10)) => error

@cloud-fan
Copy link
Contributor Author

cc @marmbrus @yhuai

@SparkQA
Copy link

SparkQA commented Dec 8, 2015

Test build #47325 has finished for PR 10196 at commit 2081673.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@marmbrus
Copy link
Contributor

marmbrus commented Dec 8, 2015

Thanks, merging to master and 1.6.

asfgit pushed a commit that referenced this pull request Dec 8, 2015
checked with hive, greatest/least should cast their children to a tightest common type,
i.e. `(int, long) => long`, `(int, string) => error`, `(decimal(10,5), decimal(5, 10)) => error`

Author: Wenchen Fan <[email protected]>

Closes #10196 from cloud-fan/type-coercion.

(cherry picked from commit 381f17b)
Signed-off-by: Michael Armbrust <[email protected]>
@asfgit asfgit closed this in 381f17b Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants