Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-12410][Streaming]Fix places that use '.' and '|' directly in split #10361

Closed
wants to merge 1 commit into from
Closed

[SPARK-12410][Streaming]Fix places that use '.' and '|' directly in split #10361

wants to merge 1 commit into from

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Dec 17, 2015

String.split accepts a regular expression, so we should escape "." and "|".

@zsxwing zsxwing changed the title [SPARK-12410][Core]Fix places that use '.' and '|' directly in split [SPARK-12410][Streaming]Fix places that use '.' and '|' directly in split Dec 17, 2015
@srowen
Copy link
Member

srowen commented Dec 17, 2015

Yes, good fix.

@SparkQA
Copy link

SparkQA commented Dec 17, 2015

Test build #47944 has finished for PR 10361 at commit bbb3e0e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member Author

zsxwing commented Dec 17, 2015

Merging to master, 1.6, 1.5 and 1.4

asfgit pushed a commit that referenced this pull request Dec 17, 2015
@zsxwing
[SPARK-12410][STREAMING] Fix places that use '.' and '|' directly in …
c0ab14f 
…split

String.split accepts a regular expression, so we should escape "." and "|".

Author: Shixiong Zhu <[email protected]>

Closes #10361 from zsxwing/reg-bug.

(cherry picked from commit 540b5ae)
Signed-off-by: Shixiong Zhu <[email protected]>
asfgit pushed a commit that referenced this pull request Dec 17, 2015
@zsxwing
[SPARK-12410][STREAMING] Fix places that use '.' and '|' directly in …
a8d14cc 
…split

String.split accepts a regular expression, so we should escape "." and "|".

Author: Shixiong Zhu <[email protected]>

Closes #10361 from zsxwing/reg-bug.

(cherry picked from commit 540b5ae)
Signed-off-by: Shixiong Zhu <[email protected]>
asfgit pushed a commit that referenced this pull request Dec 17, 2015
@zsxwing
[SPARK-12410][STREAMING] Fix places that use '.' and '|' directly in …
28adc45 
…split

String.split accepts a regular expression, so we should escape "." and "|".

Author: Shixiong Zhu <[email protected]>

Closes #10361 from zsxwing/reg-bug.

(cherry picked from commit 540b5ae)
Signed-off-by: Shixiong Zhu <[email protected]>
@asfgit asfgit closed this in 540b5ae Dec 17, 2015
@zsxwing zsxwing deleted the reg-bug branch December 17, 2015 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zsxwing @srowen @SparkQA