[SPARK-7142] [SQL] [Backport-1.5]: Minor enhancement to BooleanSimplification Optimizer rule #10383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #48011 has finished for PR 10383 at commit
|
|
Did somebody ask you to backport this? |
|
(I'm wondering about the risk of backporting "features") |
|
@rxin This is part of the offline discussion between @liancheng and @yhuai . Below is the discussion details: #10362 Thanks! |
|
@gatorsmile Since it is not for a bug fix, let's not merge it into branch 1.5. |
|
OK, I see. The problem just resolves the performance regression. Anyway, let me close it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yhuai @liancheng This PR is to backport #5700 and #8716 to branch-1.5.
Also added two more cases for ensuring it also works in multi-level filters.
Please check if it is appropriate. Thanks!