Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-12589][SQL] Fix UnsafeRowParquetRecordReader to properly set the row length. #10576

Closed
wants to merge 1 commit into from

Conversation

nongli
Copy link
Contributor

@nongli nongli commented Jan 4, 2016

The reader was previously not setting the row length meaning it was wrong if there were variable
length columns. This problem does not manifest usually, since the value in the column is correct and
projecting the row fixes the issue.

…he row length.

The reader was previously not setting the row length meaning it was wrong if there were variable
length columns. This problem does not manifest usually, since the value in the column is correct and
projecting the row fixes the issue.
@SparkQA
Copy link

SparkQA commented Jan 4, 2016

Test build #48683 has finished for PR 10576 at commit dd9dbf0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented Jan 4, 2016

LGTM. Merging to master and branch 1.6.

@asfgit asfgit closed this in 34de24a Jan 4, 2016
asfgit pushed a commit that referenced this pull request Jan 4, 2016
…he row length.

The reader was previously not setting the row length meaning it was wrong if there were variable
length columns. This problem does not manifest usually, since the value in the column is correct and
projecting the row fixes the issue.

Author: Nong Li <[email protected]>

Closes #10576 from nongli/spark-12589.

(cherry picked from commit 34de24a)
Signed-off-by: Yin Huai <[email protected]>

Conflicts:
	sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
@nongli nongli deleted the spark-12589 branch January 4, 2016 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants