Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPARK-1478.2: Upgrade FlumeInputDStream's FlumeReceiver to support FLUME-1915 #1168

Closed
wants to merge 2 commits into from
Closed

SPARK-1478.2: Upgrade FlumeInputDStream's FlumeReceiver to support FLUME-1915 #1168

wants to merge 2 commits into from

Conversation

tmalaska
Copy link

SPARK-1478.2: Upgrade FlumeInputDStream's FlumeReceiver to support
FLUME-1915

SPARK-1478: Upgrade FlumeInputDStream's Flume...
12617e5 
SPARK-1478: Upgrade FlumeInputDStream's FlumeReceiver to support
FLUME-1915
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@tmalaska tmalaska mentioned this pull request Jun 21, 2014
Closed
@tdas
Copy link
Contributor

tdas commented Jun 21, 2014

Jenkins, this is okay to test.

@tdas
Copy link
Contributor

tdas commented Jun 21, 2014

Jenkins, test this please.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished.

@AmplabJenkins
Copy link

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15985/

@tdas
Copy link
Contributor

tdas commented Jun 21, 2014

From Jenkins.
/home/jenkins/workspace/SparkPullRequestBuilder/external/flume/src/main/scala/org/apache/spark/streaming/flume/FlumeUtils.scala message=File line length exceeds 100 characters line=57

tdas
tdas reviewed Jun 21, 2014
View reviewed changes
external/flume/src/main/scala/org/apache/spark/streaming/flume/FlumeUtils.scala
storageLevel: StorageLevel,
enableDecompression: Boolean
): ReceiverInputDStream[SparkFlumeEvent] = {
val inputStream = new FlumeInputDStream[SparkFlumeEvent](ssc, hostname, port, storageLevel, enableDecompression)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lines is too long.

@tmalaska
Copy link
Author

Thanks tdas I messed that one. I just updated. It should be good now.

@tdas
Copy link
Contributor

tdas commented Jun 22, 2014

Jenkins, test this please

@tdas
Copy link
Contributor

tdas commented Jun 22, 2014

Jenkins, add to whitelist

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished.

@AmplabJenkins
Copy link

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16002/

@tdas
Copy link
Contributor

tdas commented Jun 24, 2014

This is a weird binary compatibility check failure, that should not be thrown. We are looking at our end for fixing this and rerunning the tests. Once this is figured out, I will merge this.

@tmalaska
Copy link
Author

Let me know if there is anything I can do to help.
On Jun 24, 2014 6:33 PM, "Tathagata Das" [email protected] wrote:

This is a weird binary compatibility check failure, that should not be
thrown. We are looking at our end for fixing this and rerunning the tests.
Once this is figured out, I will merge this.

—
Reply to this email directly or view it on GitHub
#1168 (comment).

@tdas
Copy link
Contributor

tdas commented Jul 3, 2014

Jenkins, test this again.

@tdas
Copy link
Contributor

tdas commented Jul 4, 2014

Jenkins, test this.

@tmalaska
Copy link
Author

tmalaska commented Jul 7, 2014

What is the status of this Jira?

@tdas
Copy link
Contributor

tdas commented Jul 8, 2014

Jenkins, test this please.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@tdas
Copy link
Contributor

tdas commented Jul 8, 2014

@tmalaska The binary issue is a pretty tricky issue and doesnt look like it will be fixed any time soon. For now, I am going to try to do work around by ignoring this check (once the latest jenkins build is over, and I have found what to override). Might pull in your changes into my own branch and issue a new PR.
In the meantime, could you close the previous PR, it getting confusing. :)

@tdas
Copy link
Contributor

tdas commented Jul 8, 2014

Got the error, going to fix it.

@AmplabJenkins
Copy link

Merged build finished.

@AmplabJenkins
Copy link

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16419/

@tmalaska
Copy link
Author

tmalaska commented Jul 8, 2014

Let me know if I need to do anything

@tdas tdas mentioned this pull request Jul 9, 2014
Closed
@tmalaska
Copy link
Author

tmalaska commented Jul 9, 2014

Done. I closed 566.

Anything else. I'm open to work on anything. Just direct me to a jira.

@tdas
Copy link
Contributor

tdas commented Jul 9, 2014

Ummm. I meant could you close this PR. :)

asfgit pushed a commit that referenced this pull request Jul 10, 2014
@tdas
[SPARK-1478].3: Upgrade FlumeInputDStream's FlumeReceiver to support …
40a8fef 
…FLUME-1915

This is a modified version of this PR #1168 done by @tmalaska
Adds MIMA binary check exclusions.

Author: tmalaska <[email protected]>
Author: Tathagata Das <[email protected]>

Closes #1347 from tdas/FLUME-1915 and squashes the following commits:

96065df [Tathagata Das] Added Mima exclusion for FlumeReceiver.
41d5338 [tmalaska] Address line 57 that was too long
12617e5 [tmalaska] SPARK-1478: Upgrade FlumeInputDStream's Flume...
@tdas
Copy link
Contributor

tdas commented Jul 10, 2014

@tmalaska can you close this? :)

@tmalaska tmalaska closed this Jul 12, 2014
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@conviva-zz
[SPARK-1478].3: Upgrade FlumeInputDStream's FlumeReceiver to support …
a18fcff 
…FLUME-1915

This is a modified version of this PR apache#1168 done by @tmalaska
Adds MIMA binary check exclusions.

Author: tmalaska <[email protected]>
Author: Tathagata Das <[email protected]>

Closes apache#1347 from tdas/FLUME-1915 and squashes the following commits:

96065df [Tathagata Das] Added Mima exclusion for FlumeReceiver.
41d5338 [tmalaska] Address line 57 that was too long
12617e5 [tmalaska] SPARK-1478: Upgrade FlumeInputDStream's Flume...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmalaska @AmplabJenkins @tdas