-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-18198][Doc][Streaming] Highlight code snippets #15715
Conversation
@koeninger @srowen it'd be great if you could also take a look at this too :) Hint: this patch consists of two commits:
|
That is nicer. Are there any other code snippets across the code base that need this treatment? seems like this is always the right thing to do. |
@srowen thanks. I'm afraid the streaming And as far as I can tell, no other code snippets need this treatment. |
Test build #67899 has finished for PR 15715 at commit
|
What about unindenting those blocks? I don't see why they have to be in the first place. They're HTML tags. |
What about keeping the indent of the div tags but un-indenting only the code? it might look weird in markdown but does it look nice in the rendered output? If it's any more trouble than that, forget it. |
I guess we could restructure the headings to not have these numbered, indented sections to begin with, but that's a separate task I think. |
Sounds good! |
LGTM |
+1 |
Merged to master |
@srowen thanks -- could we also merge this into branch-2.1? |
## What changes were proposed in this pull request? This patch uses `{% highlight lang %}...{% endhighlight %}` to highlight code snippets in the `Structured Streaming Kafka010 integration doc` and the `Spark Streaming Kafka010 integration doc`. This patch consists of two commits: - the first commit fixes only the leading spaces -- this is large - the second commit adds the highlight instructions -- this is much simpler and easier to review ## How was this patch tested? SKIP_API=1 jekyll build ## Screenshots **Before** ![snip20161101_3](https://cloud.githubusercontent.com/assets/15843379/19894258/47746524-a087-11e6-9a2a-7bff2d428d44.png) **After** ![snip20161101_1](https://cloud.githubusercontent.com/assets/15843379/19894324/8bebcd1e-a087-11e6-835b-88c4d2979cfa.png) Author: Liwei Lin <[email protected]> Closes #15715 from lw-lin/doc-highlight-code-snippet. (cherry picked from commit 98ede49) Signed-off-by: Sean Owen <[email protected]>
Oops, I see, we've cut branch 2.1. I must have missed that one too along with other dev@ lists going to spam. Yes I will go back and make sure a few I've just merged to master are in 2.1. |
## What changes were proposed in this pull request? This patch uses `{% highlight lang %}...{% endhighlight %}` to highlight code snippets in the `Structured Streaming Kafka010 integration doc` and the `Spark Streaming Kafka010 integration doc`. This patch consists of two commits: - the first commit fixes only the leading spaces -- this is large - the second commit adds the highlight instructions -- this is much simpler and easier to review ## How was this patch tested? SKIP_API=1 jekyll build ## Screenshots **Before** ![snip20161101_3](https://cloud.githubusercontent.com/assets/15843379/19894258/47746524-a087-11e6-9a2a-7bff2d428d44.png) **After** ![snip20161101_1](https://cloud.githubusercontent.com/assets/15843379/19894324/8bebcd1e-a087-11e6-835b-88c4d2979cfa.png) Author: Liwei Lin <[email protected]> Closes apache#15715 from lw-lin/doc-highlight-code-snippet.
What changes were proposed in this pull request?
This patch uses
{% highlight lang %}...{% endhighlight %}
to highlight code snippets in theStructured Streaming Kafka010 integration doc
and theSpark Streaming Kafka010 integration doc
.This patch consists of two commits:
How was this patch tested?
SKIP_API=1 jekyll build
Screenshots
Before
After