[SPARK-18508][SQL] Fix documentation error for DateDiff #15937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxin
changed the title
|
Test build #68882 has started for PR 15937 at commit |
|
LGTM Sorry, I did not catch this. |
|
Test FAILed. |
srowen
approved these changes
Nov 19, 2016
|
Hi @rxin, actually, I found another wrong example in in - > SELECT _FUNC_(' ', Spark', 'SQL');
+ > SELECT _FUNC_(' ', 'Spark', 'SQL');If you don't mind and it sounds good, this might be able to be included here together. BTW, there were plenty of wrong examples fixed in the last PR but it seems I missed some. |
|
Thanks I will fix that too. Merging this in master/branch-2.1. |
asfgit
pushed a commit
that referenced
this pull request
Nov 20, 2016
## What changes were proposed in this pull request? The previous documentation and example for DateDiff was wrong. ## How was this patch tested? Doc only change. Author: Reynold Xin <[email protected]> Closes #15937 from rxin/datediff-doc. (cherry picked from commit bce9a03) Signed-off-by: Reynold Xin <[email protected]>
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Nov 20, 2016
## What changes were proposed in this pull request? The previous documentation and example for DateDiff was wrong. ## How was this patch tested? Doc only change. Author: Reynold Xin <[email protected]> Closes apache#15937 from rxin/datediff-doc.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? The previous documentation and example for DateDiff was wrong. ## How was this patch tested? Doc only change. Author: Reynold Xin <[email protected]> Closes apache#15937 from rxin/datediff-doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The previous documentation and example for DateDiff was wrong.
How was this patch tested?
Doc only change.