[SPARK-18751][Core]Fix deadlock when SparkContext.stop is called in Utils.tryOrStopSparkContext #16178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsxwing
changed the title
|
cc @rxin |
marmbrus
reviewed
Dec 6, 2016
| _stop() | ||
| } | ||
| override def run(): Unit = { | ||
| SparkContext.this.stop() |
There was a problem hiding this comment.
Will this ever throw an exception? Should we register an UncaughtExceptionHandler or try catch with logging?
There was a problem hiding this comment.
Will this ever throw an exception? Should we register an UncaughtExceptionHandler or try catch with logging?
This happens in the driver, so we cannot use SparkUncaughtExceptionHandler to catch the error. The error will be sent to the user's UncaughtExceptionHandler if specified or just print to stderr.
vanzin
reviewed
Dec 6, 2016
| /** | ||
| * Shut down the SparkContext. | ||
| */ | ||
| def stop() { |
There was a problem hiding this comment.
This needs a proper signature (...: Unit = {)
|
Test build #69750 has finished for PR 16178 at commit
|
|
Test build #69751 has finished for PR 16178 at commit
|
|
Test build #69821 has finished for PR 16178 at commit
|
|
LGTM |
|
Thanks! Merging to master and 2.1. |
asfgit
pushed a commit
that referenced
this pull request
Dec 8, 2016
…Utils.tryOrStopSparkContext ## What changes were proposed in this pull request? When `SparkContext.stop` is called in `Utils.tryOrStopSparkContext` (the following three places), it will cause deadlock because the `stop` method needs to wait for the thread running `stop` to exit. - ContextCleaner.keepCleaning - LiveListenerBus.listenerThread.run - TaskSchedulerImpl.start This PR adds `SparkContext.stopInNewThread` and uses it to eliminate the potential deadlock. I also removed my changes in #15775 since they are not necessary now. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes #16178 from zsxwing/fix-stop-deadlock. (cherry picked from commit 26432df) Signed-off-by: Shixiong Zhu <[email protected]>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 15, 2016
…Utils.tryOrStopSparkContext ## What changes were proposed in this pull request? When `SparkContext.stop` is called in `Utils.tryOrStopSparkContext` (the following three places), it will cause deadlock because the `stop` method needs to wait for the thread running `stop` to exit. - ContextCleaner.keepCleaning - LiveListenerBus.listenerThread.run - TaskSchedulerImpl.start This PR adds `SparkContext.stopInNewThread` and uses it to eliminate the potential deadlock. I also removed my changes in apache#15775 since they are not necessary now. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes apache#16178 from zsxwing/fix-stop-deadlock.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…Utils.tryOrStopSparkContext ## What changes were proposed in this pull request? When `SparkContext.stop` is called in `Utils.tryOrStopSparkContext` (the following three places), it will cause deadlock because the `stop` method needs to wait for the thread running `stop` to exit. - ContextCleaner.keepCleaning - LiveListenerBus.listenerThread.run - TaskSchedulerImpl.start This PR adds `SparkContext.stopInNewThread` and uses it to eliminate the potential deadlock. I also removed my changes in apache#15775 since they are not necessary now. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes apache#16178 from zsxwing/fix-stop-deadlock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When
SparkContext.stopis called inUtils.tryOrStopSparkContext(the following three places), it will cause deadlock because thestopmethod needs to wait for the thread runningstopto exit.This PR adds
SparkContext.stopInNewThreadand uses it to eliminate the potential deadlock. I also removed my changes in #15775 since they are not necessary now.How was this patch tested?
Jenkins