-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-12297][SQL] Hive compatibility for Parquet Timestamps #16781
Closed
Closed
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
53d0744
very basic test for adjusting read parquet data
squito 69a3c8c
wip
squito 51e24f2
working version for non-vectorized read -- lots of garbage too
squito 7e61841
working for vectorized reads -- not sure about all code paths
squito 9fbde13
more tests for write path
squito bac9eb0
expand tests; fix some metastore interaction; cleanup a lot of garbage
squito 1b05978
more cleanup
squito b622d27
handle bad timezones; include unit test
squito 0604403
write support; lots more unit tests
squito f45516d
add tests for alter table
squito d4511a6
utc or gmt; cleanup
squito 223ce2c
more cleanup
squito 5b49ae0
fix compatibility
squito 9ef60a4
Merge branch 'master' into SPARK-12297
squito 0b6883c
Merge branch 'master' into SPARK-12297
squito 69b8142
wip
squito 7ca2c86
fix
squito 6f982d3
fixes; passes tests now
squito 1ad2f83
Merge branch 'master' into SPARK-12297
squito 2c8a228
fix merge
squito f0b89fd
fix
squito db0216f
Merge branch 'master' into SPARK-12297
squito 46fab8d
refactor the test
squito c242fb8
cleanup
squito c87a573
reset timezone property after tests; make tests more granular
squito db7e514
Merge branch 'master' into SPARK-12297
squito f4dca27
separate tests for reading & writing
squito 2891582
Merge branch 'master' into SPARK-12297
squito d951443
fix merge
squito 38e19cd
Merge branch 'master' into SPARK-12297
squito 1e3b768
Merge branch 'master' into SPARK-12297
squito 39f506c
cleanup
squito f33bc91
Merge branch 'master' into SPARK-12297
squito 17565e8
remove config for setting table time zone automatically
squito a96806f
fixup
squito 7582b2c
predicate pushdown tests
squito 5817064
minor cleanup
squito 773704a
Merge branch 'master' into SPARK-12297
squito be134be
fix merge
squito d15b660
swap conversion logic
squito 283b1c7
update tests a bunch; tests session timezones, and tests are easier t…
squito 6ccaa92
session timezones
squito 71c7e60
cleanup
squito 75e8579
Merge branch 'master' into SPARK-12297
squito e4e88a5
partial review feedback
squito 44a8bbb
better param names and docs
squito e31657a
review feedback
squito d4ff9fd
Merge branch 'master' into SPARK-12297
squito acc72ea
add check for partitioned tables
squito b9c03e9
fix typo
squito fc17a2e
review feedback
squito 2537437
review feedback
squito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be case insensitive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Java does a case-sensitive check, which means Hive does too. I don't think we want to write out a timezone w/ the wrong capitalization, and then have another tool throw an error.
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/timestamp/NanoTimeUtils.java#L167
We could try to auto-convert the user's timezone to the correct capitilazation, but do you think that is worth it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. Let's keep current work.