Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-20543][SPARKR] skip tests when running on CRAN #17817

Closed
wants to merge 3 commits into from

Conversation

felixcheung
Copy link
Member

@felixcheung felixcheung commented May 1, 2017

What changes were proposed in this pull request?

General rule on skip or not:
skip if

  • RDD tests
  • tests could run long or complicated (streaming, hivecontext)
  • tests on error conditions
  • tests won't likely change/break

How was this patch tested?

unit tests, R CMD check --as-cran, R CMD check

@SparkQA
Copy link

SparkQA commented May 1, 2017

Test build #76342 has finished for PR 17817 at commit fc4965a.

  • This patch fails R style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 1, 2017

Test build #76343 has finished for PR 17817 at commit 2c5e267.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 1, 2017

Test build #76346 has finished for PR 17817 at commit bd3295a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member Author

felixcheung commented May 1, 2017

@felixcheung felixcheung changed the title [SPARK-20543][SPARKR][WIP] skip tests when running on CRAN [SPARK-20543][SPARKR] skip tests when running on CRAN May 1, 2017
@asfgit asfgit closed this in fc472bd May 4, 2017
asfgit pushed a commit that referenced this pull request May 4, 2017
General rule on skip or not:
skip if
- RDD tests
- tests could run long or complicated (streaming, hivecontext)
- tests on error conditions
- tests won't likely change/break

unit tests, `R CMD check --as-cran`, `R CMD check`

Author: Felix Cheung <[email protected]>

Closes #17817 from felixcheung/rskiptest.

(cherry picked from commit fc472bd)
Signed-off-by: Felix Cheung <[email protected]>
@felixcheung
Copy link
Member Author

merged to master/2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants