[SparkR][Doc] fix typo in vignettes #17884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #76527 has finished for PR 17884 at commit
|
|
I know it is legitimate but It would be worth double checking other typos too. Usually, single typo PR is not encouraged up to my knowledge given reviwing, building and merging costs. |
|
@HyukjinKwon Thanks for pointing this out. I will keep this in mind next time. |
|
This test seems flaky on AppVeyor, not sure why |
|
@actuaryzhang thanks - would you have a chance to run a quick QA check on the rest of the vignettes, if you haven't already? |
|
@felixcheung I ran a quick QA on the vignettes and fixed some additional typos and styles. |
|
Test build #76534 has finished for PR 17884 at commit
|
felixcheung
approved these changes
May 7, 2017
R/pkg/vignettes/sparkr-vignettes.Rmd
Outdated
| @@ -405,7 +405,7 @@ result <- gapply( | |||
| head(arrange(result, "max_mpg", decreasing = TRUE)) | |||
| ``` | |||
|
|
|||
| Like gapply, `gapplyCollect` applies a function to each partition of a `SparkDataFrame` and collect the result back to R `data.frame`. The output of the function should be a `data.frame` but no schema is required in this case. Note that `gapplyCollect` can fail if the output of UDF run on all the partition cannot be pulled to the driver and fit in driver memory. | |||
| Like gapply, `gapplyCollect` applies a function to each partition of a `SparkDataFrame` and collect the result back to R `data.frame`. The output of the function should be a `data.frame` but no schema is required in this case. Note that `gapplyCollect` can fail if the output of the UDF on all partitions cannot be pulled into the driver's memory. | |||
There was a problem hiding this comment.
could you add backtick to gapply at the beginning
| @@ -1079,19 +1079,19 @@ There are three main object classes in SparkR you may be working with. | |||
| + `sdf` stores a reference to the corresponding Spark Dataset in the Spark JVM backend. | |||
| + `env` saves the meta-information of the object such as `isCached`. | |||
|
|
|||
| It can be created by data import methods or by transforming an existing `SparkDataFrame`. We can manipulate `SparkDataFrame` by numerous data processing functions and feed that into machine learning algorithms. | |||
| It can be created by data import methods or by transforming an existing `SparkDataFrame`. We can manipulate `SparkDataFrame` by numerous data processing functions and feed that into machine learning algorithms. | |||
There was a problem hiding this comment.
just curious, does this whitespace in front of paragraph get handled properly?
There was a problem hiding this comment.
@felixcheung Yes, the four spaces indicate that the text following should be aligned with the bullet point. Otherwise, it will start as a new paragraph and have the wrong indention.
You will see the difference after compiling the Rmarkdown file.
|
Test build #76555 has finished for PR 17884 at commit
|
asfgit
pushed a commit
that referenced
this pull request
May 8, 2017
## What changes were proposed in this pull request? Fix typo in vignettes Author: Wayne Zhang <[email protected]> Closes #17884 from actuaryzhang/typo. (cherry picked from commit 2fdaeb5) Signed-off-by: Felix Cheung <[email protected]>
|
merged to master/2.2 |
liyichao
pushed a commit
to liyichao/spark
that referenced
this pull request
May 24, 2017
## What changes were proposed in this pull request? Fix typo in vignettes Author: Wayne Zhang <[email protected]> Closes apache#17884 from actuaryzhang/typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix typo in vignettes