-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jenkins] Fix Jenkins not posting to Github sometimes #1809
Conversation
test this please |
Andrew, could you post an example of a class definition that causes this? I'm working on a related PR, so I'm curious. Also, have you looked into using |
Oh interesting, I didn't realize there was a related PR. Try adding a default parameter to your class:
This is because the curl doesn't escape the double quotes properly. I'm having some difficulty trying to get Jenkins to test this PR, however, so maybe you can try to fix this in yours. |
Yeah, Jenkins and I are good buddies now. Heh. I'll take a crack at fixing this in my PR in parallel. |
Let me know once you fix it so I can give up on grabbing Jenkin's attention and close this PR. |
I think I've got it. Check it out. I also have the typo fixed in my PR, btw. (Fixed by removing the entire sentence, actually. 🤘) |
You can find the [discussion that motivated this PR here](http://mail-archives.apache.org/mod_mbox/spark-dev/201408.mbox/%3CCABPQxssy0ri2QAz=cc9Tx+EXYWARm7pNcVm8apqCwc-esLbO4Qmail.gmail.com%3E). As described in [SPARK-2912](https://issues.apache.org/jira/browse/SPARK-2912), the goal of this PR (and related ones to come) is to include useful detail in Spark QA's messages that are intended to make a committer's job easier to do. Since this work depends on Jenkins, I cannot test this locally. Hence, I will be iterating via this PR. Notes: * This is a duplicate of a [previous PR](#1811), without the extraneous commits. * This PR also resolves an issue targeted by [another open PR](#1809). Closes #1809. Author: Nicholas Chammas <[email protected]> Author: nchammas <[email protected]> Closes #1816 from nchammas/master and squashes the following commits: c1be644 [Nicholas Chammas] [SPARK-2912] include commit hash in messages 8f641ac [nchammas] Merge pull request #7 from apache/master
You can find the [discussion that motivated this PR here](http://mail-archives.apache.org/mod_mbox/spark-dev/201408.mbox/%3CCABPQxssy0ri2QAz=cc9Tx+EXYWARm7pNcVm8apqCwc-esLbO4Qmail.gmail.com%3E). As described in [SPARK-2912](https://issues.apache.org/jira/browse/SPARK-2912), the goal of this PR (and related ones to come) is to include useful detail in Spark QA's messages that are intended to make a committer's job easier to do. Since this work depends on Jenkins, I cannot test this locally. Hence, I will be iterating via this PR. Notes: * This is a duplicate of a [previous PR](apache#1811), without the extraneous commits. * This PR also resolves an issue targeted by [another open PR](apache#1809). Closes apache#1809. Author: Nicholas Chammas <[email protected]> Author: nchammas <[email protected]> Closes apache#1816 from nchammas/master and squashes the following commits: c1be644 [Nicholas Chammas] [SPARK-2912] include commit hash in messages 8f641ac [nchammas] Merge pull request apache#7 from apache/master
If your diff has "class" and double quotes on the same line, Jenkins does not post back to github because the diff is not properly escaped.