Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPARK-3020: Print completed indices rather than tasks in web UI #1933

Closed
wants to merge 2 commits into from
Closed

SPARK-3020: Print completed indices rather than tasks in web UI #1933

wants to merge 2 commits into from

Conversation

pwendell
Copy link
Contributor

No description provided.

@SparkQA
Copy link

SparkQA commented Aug 13, 2014

QA tests have started for PR 1933. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18494/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 14, 2014

QA tests have started for PR 1933. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18497/consoleFull

@pwendell
Copy link
Contributor Author

@rxin I used OpenHashSet here. I'm hesitant to convert this into an integer when the stage completes, because we still haven't dealt correctly with stage re-submissionsa and as it stands I think it's not easy to reason about the last time taskEnded will be called for a given stage.

rxin
rxin reviewed Aug 14, 2014
View reviewed changes
core/src/main/scala/org/apache/spark/ui/jobs/UIData.scala
@@ -38,6 +39,7 @@ private[jobs] object UIData {
class StageUIData {
var numActiveTasks: Int = _
var numCompleteTasks: Int = _
var completedIndices = new OpenHashSet[Int]()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo

@rxin
Copy link
Contributor

rxin commented Aug 14, 2014

lgtm other than the todo

@SparkQA
Copy link

SparkQA commented Aug 14, 2014

QA results for PR 1933:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18494/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 14, 2014

QA results for PR 1933:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18497/consoleFull

@rxin
Copy link
Contributor

rxin commented Aug 14, 2014

Thanks. Merging in master & branch-1.1.

asfgit pushed a commit that referenced this pull request Aug 14, 2014
@pwendell @rxin
SPARK-3020: Print completed indices rather than tasks in web UI
c6cb55a 
Author: Patrick Wendell <[email protected]>

Closes #1933 from pwendell/speculation and squashes the following commits:

33a3473 [Patrick Wendell] Use OpenHashSet
8ce2ff0 [Patrick Wendell] SPARK-3020: Print completed indices rather than tasks in web UI

(cherry picked from commit 0c7b452)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 0c7b452 Aug 14, 2014
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@pwendell @conviva-zz
SPARK-3020: Print completed indices rather than tasks in web UI
6b98eb8 
Author: Patrick Wendell <[email protected]>

Closes apache#1933 from pwendell/speculation and squashes the following commits:

33a3473 [Patrick Wendell] Use OpenHashSet
8ce2ff0 [Patrick Wendell] SPARK-3020: Print completed indices rather than tasks in web UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pwendell @SparkQA @rxin