[SPARK-22688][SQL] Upgrade Janino version to 3.0.8

[kiszk]

What changes were proposed in this pull request?

This PR upgrade Janino version to 3.0.8. Janino 3.0.8 includes an important fix to reduce the number of constant pool entries by using 'sipush' java bytecode.

• SIPUSH bytecode is not used for short integer constant #33.

Please see detail in this discussion thread.

How was this patch tested?

Existing tests

[srowen]

Sounds good. This should also go back to branch-2.1 like the previous update to 3.0.7, but note that there are more deps files to update in that branch.

[SparkQA]

Test build #84465 has finished for PR 19890 at commit 68b24c9.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[kiszk]

@srowen thank you for pointing it out.
Here is an example at 3.0.7.

[gatorsmile]

Wait...

Renamed the "JaninoRuntimeException" to "InternalCompilerException" (and left the old class for backwards compatibility), because the old name was confusing.

We captured JaninoRuntimeException. Does that mean we need to also Capture InternalCompilerException if we upgrade it?

@kiszk Could you double check it?

[kiszk]

@gatorsmile great catch, I will double check it.

[kiszk]

@gatorsmile The current code works functionally correct since InternalCompilerException is defined as a subclass of JaninoRuntimeException. On the other hand, JaninoRuntimeException is deprecated now.

Do we replace JaninoRuntimeException in Spark code with InternalCompilerException?
I do not have strong preference.

[HyukjinKwon]

Yea, let's avoid using deprecated ones, of course if it does not break anything.

[kiszk]

Sure

[SparkQA]

Test build #84545 has finished for PR 19890 at commit 663803b.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

It would only cause a problem if somehow and older Janino was on the classpath, which does not have the new exception type. I don't think there's a reason to believe that happens in practice (i.e. not brought in by Hadoop).

[gatorsmile]

cc @hvanhovell @cloud-fan @rednaxelafx

[rednaxelafx]

I'd LGTM on both upgrading to Janino 3.0.8 and also changing the exception type captured from JaninoRuntimeException to the new InternalCompilerException. It's never a good idea to have conflicting library version on the classpath anyway, hitting an error in terms of ClassNotFoundException or NoClassDefFoundError on this new exception type is actually a good hint that there is a version conflict -- it'd be nice if we can document this knowledge somewhere easy to find, though.

[gatorsmile]

LGTM

[gatorsmile]

Thanks! Merged to master.

[srowen]

We'll need to back port to 2.2/2.1 to match the previous janino update. I'll do that. A different PR will be required for 2.1