Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-27178][k8s][branch-2.4] adding nss package to fix tests #24137

Closed
wants to merge 1 commit into from

Conversation

shaneknapp
Copy link
Contributor

What changes were proposed in this pull request?

see also: #24111

while performing some tests on our existing minikube and k8s infrastructure, i noticed that the integration tests were failing. i dug in and discovered the following message buried at the end of the stacktrace:

  Caused by: java.io.FileNotFoundException: /usr/lib/libnss3.so
  	at sun.security.pkcs11.Secmod.initialize(Secmod.java:193)
  	at sun.security.pkcs11.SunPKCS11.<init>(SunPKCS11.java:218)
  	... 81 more

after i added the nss package to resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile, everything worked.

this is also impacting current builds. see: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8959/console

How was this patch tested?

i tested locally before pushing, and the build system will test the rest.

@shaneknapp shaneknapp changed the title adding nss package to fix tests [SPARK-27178][k8s][branch-2.4] adding nss package to fix tests Mar 18, 2019
@SparkQA
Copy link

SparkQA commented Mar 18, 2019

@SparkQA
Copy link

SparkQA commented Mar 18, 2019

Test build #103636 has finished for PR 24137 at commit 8772a3d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Mar 18, 2019

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/9037/

@shaneknapp
Copy link
Contributor Author

just to confirm, i'm running the integration tests locally w/o the nss package in the dockerfile. once that test fails, we can be certain that this PR fixes the issue.

@shaneknapp
Copy link
Contributor Author

shaneknapp commented Mar 18, 2019

...and there it is (confirmed failure on the jenkins environment w/o the `nss' package):

Caused by: java.io.FileNotFoundException: /usr/lib/libnss3.so
        at sun.security.pkcs11.Secmod.initialize(Secmod.java:193)
        at sun.security.pkcs11.SunPKCS11.<init>(SunPKCS11.java:218)
        ... 83 more

this PR is g2g in to 2.4, pending the decision if this makes an RC cut (i brought this up on dev@ as well).

@srowen @vanzin @dbtsai

@vanzin
Copy link
Contributor

vanzin commented Mar 18, 2019

Merging to 2.4.

vanzin pushed a commit that referenced this pull request Mar 18, 2019
## What changes were proposed in this pull request?

see also:  #24111

while performing some tests on our existing minikube and k8s infrastructure, i noticed that the integration tests were failing. i dug in and discovered the following message buried at the end of the stacktrace:

```
  Caused by: java.io.FileNotFoundException: /usr/lib/libnss3.so
  	at sun.security.pkcs11.Secmod.initialize(Secmod.java:193)
  	at sun.security.pkcs11.SunPKCS11.<init>(SunPKCS11.java:218)
  	... 81 more
```
after i added the `nss` package to `resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile`, everything worked.

this is also impacting current builds.  see:  https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8959/console

## How was this patch tested?

i tested locally before pushing, and the build system will test the rest.

Closes #24137 from shaneknapp/add-nss-package.

Authored-by: shane knapp <[email protected]>
Signed-off-by: Marcelo Vanzin <[email protected]>
@vanzin vanzin closed this Mar 18, 2019
@dbtsai
Copy link
Member

dbtsai commented Mar 19, 2019

@shaneknapp thanks for pinging me. I am still stuck on nexus publishing for rc8, and Apache Infra team is helping me on that. Once they help me to get jars right on repo, how about I send out another vote for rc8, and we can discuss there? Thanks!

@skonto
Copy link
Contributor

skonto commented Mar 19, 2019

@shaneknapp did something change with openjdk:8-alpine ? I think we shouldnt use latest for better control. On the other hand, I did check the images and all contain that lib. Also check the file list here:
https://pkgs.alpinelinux.org/contents?file=&path=&name=nss&branch=edge&repo=main&arch=x86
Something else is lurking here...

@vanzin
Copy link
Contributor

vanzin commented Mar 19, 2019

Stavros, see #24111

markhamstra pushed a commit to markhamstra/spark that referenced this pull request Mar 21, 2019
see also:  apache#24111

while performing some tests on our existing minikube and k8s infrastructure, i noticed that the integration tests were failing. i dug in and discovered the following message buried at the end of the stacktrace:

```
  Caused by: java.io.FileNotFoundException: /usr/lib/libnss3.so
  	at sun.security.pkcs11.Secmod.initialize(Secmod.java:193)
  	at sun.security.pkcs11.SunPKCS11.<init>(SunPKCS11.java:218)
  	... 81 more
```
after i added the `nss` package to `resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile`, everything worked.

this is also impacting current builds.  see:  https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8959/console

i tested locally before pushing, and the build system will test the rest.

Closes apache#24137 from shaneknapp/add-nss-package.

Authored-by: shane knapp <[email protected]>
Signed-off-by: Marcelo Vanzin <[email protected]>
@shaneknapp shaneknapp deleted the add-nss-package branch April 19, 2019 17:35
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Jul 23, 2019
## What changes were proposed in this pull request?

see also:  apache#24111

while performing some tests on our existing minikube and k8s infrastructure, i noticed that the integration tests were failing. i dug in and discovered the following message buried at the end of the stacktrace:

```
  Caused by: java.io.FileNotFoundException: /usr/lib/libnss3.so
  	at sun.security.pkcs11.Secmod.initialize(Secmod.java:193)
  	at sun.security.pkcs11.SunPKCS11.<init>(SunPKCS11.java:218)
  	... 81 more
```
after i added the `nss` package to `resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile`, everything worked.

this is also impacting current builds.  see:  https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8959/console

## How was this patch tested?

i tested locally before pushing, and the build system will test the rest.

Closes apache#24137 from shaneknapp/add-nss-package.

Authored-by: shane knapp <[email protected]>
Signed-off-by: Marcelo Vanzin <[email protected]>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Jul 25, 2019
## What changes were proposed in this pull request?

see also:  apache#24111

while performing some tests on our existing minikube and k8s infrastructure, i noticed that the integration tests were failing. i dug in and discovered the following message buried at the end of the stacktrace:

```
  Caused by: java.io.FileNotFoundException: /usr/lib/libnss3.so
  	at sun.security.pkcs11.Secmod.initialize(Secmod.java:193)
  	at sun.security.pkcs11.SunPKCS11.<init>(SunPKCS11.java:218)
  	... 81 more
```
after i added the `nss` package to `resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile`, everything worked.

this is also impacting current builds.  see:  https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8959/console

## How was this patch tested?

i tested locally before pushing, and the build system will test the rest.

Closes apache#24137 from shaneknapp/add-nss-package.

Authored-by: shane knapp <[email protected]>
Signed-off-by: Marcelo Vanzin <[email protected]>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Aug 1, 2019
## What changes were proposed in this pull request?

see also:  apache#24111

while performing some tests on our existing minikube and k8s infrastructure, i noticed that the integration tests were failing. i dug in and discovered the following message buried at the end of the stacktrace:

```
  Caused by: java.io.FileNotFoundException: /usr/lib/libnss3.so
  	at sun.security.pkcs11.Secmod.initialize(Secmod.java:193)
  	at sun.security.pkcs11.SunPKCS11.<init>(SunPKCS11.java:218)
  	... 81 more
```
after i added the `nss` package to `resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile`, everything worked.

this is also impacting current builds.  see:  https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8959/console

## How was this patch tested?

i tested locally before pushing, and the build system will test the rest.

Closes apache#24137 from shaneknapp/add-nss-package.

Authored-by: shane knapp <[email protected]>
Signed-off-by: Marcelo Vanzin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants