-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-3479] [Build] Report failed test category #2606
Conversation
I'm gonna post several test commits here to try out the various failure modes and confirm that they are reported correctly. |
0f6dcd3
to
cc243c9
Compare
QA tests have started for PR 2606 at commit
|
QA tests have finished for PR 2606 at commit
|
Test FAILed. |
Test FAILed. |
Test FAILed. |
Jenkins failed to checkout the patch. Jenkins, retest this please. |
Jenkins, retest this please. |
Test FAILed. |
Jenkins, retest this please. |
QA tests have started for PR 2606 at commit
|
QA tests have finished for PR 2606 at commit
|
Test FAILed. |
Test FAILed. |
Grr, Jenkins flakiness checking out stuff from git... Oi Jenkins! Retest this please. |
Jenkins, retest this please. |
QA tests have started for PR 2606 at commit
|
QA tests have finished for PR 2606 at commit
|
Test FAILed. |
QA tests have started for PR 2606 at commit
|
QA tests have started for PR 2606 at commit
|
QA tests have finished for PR 2606 at commit
|
Test FAILed. |
QA tests have finished for PR 2606 at commit
|
Test FAILed. |
QA tests have started for PR 2606 at commit
|
QA tests have finished for PR 2606 at commit
|
Test FAILed. |
QA tests have started for PR 2606 at commit
|
sigh... more checkout troubles. |
Jenkins, retest this please. |
QA tests have started for PR 2606 at commit
|
QA tests have finished for PR 2606 at commit
|
Test FAILed. |
Hmm, I expected a failure in the PySpark doctests, not here. |
Jenkins, retest this please. |
Test FAILed. |
Another checkout timeout. |
Jenkins, retest this please. |
QA tests have started for PR 2606 at commit
|
QA tests have finished for PR 2606 at commit
|
Test FAILed. |
f137249
to
d67df03
Compare
QA tests have started for PR 2606 at commit
|
QA tests have finished for PR 2606 at commit
|
Test PASSed. |
cc @pwendell This PR is ready for review. Here are examples of the messages posted when: |
else | ||
merge_note=" * This patch merges cleanly." | ||
fi | ||
|
||
source_files=$( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do a valid diff regardless of the merge-ability of the patch, so I moved this out of the if block.
This looks great! Thanks for adding the extra comments to explain the |
@pwendell @JoshRosen Is this PR ready to be merged in? |
Sure, this looks fine to me so I'm going to merge it now. Thanks! |
This PR allows SparkQA (i.e. Jenkins) to report in its posts to GitHub what category of test failed, if one can be determined.
The failure categories are:
This PR also fixes the diffing logic used to determine if a patch introduces new classes.