[SPARK-29528][BUILD][test-maven] Upgrade scala-maven-plugin to 4.2.4 for Scala 2.13.1 #26185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
|
Retest this please. |
|
Test build #112351 has finished for PR 26185 at commit
|
|
Test build #112352 has finished for PR 26185 at commit
|
|
Merged to master. |
|
Thank you for review and merging, @HyukjinKwon ! |
|
Ah .. sorry @dongjoon-hyun, this seems causing the build failure on Windows (#26278). Let me revert this one for preview, and then get this in after the preview just to make sure all tests pass. |
|
No problem~ Thanks! |
|
I made a new attempt with 4.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR upgrades
scala-maven-pluginto4.2.4for Scala2.13.1.Why are the changes needed?
Scala 2.13.1 seems to break the binary compatibility.
We need to upgrade
scala-maven-pluginto bring the the following fixes for the latest Scala 2.13.1.Does this PR introduce any user-facing change?
No.
How was this patch tested?
For now, we don't support Scala-2.13. This PR at least needs to pass the existing Jenkins with Maven to get prepared for Scala-2.13.