[SPARK-30698][BUILD] Bumps checkstyle from 8.25 to 8.29. #27426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ur, @beliefer . If you say |
|
@dongjoon-hyun I'm sorry! What should write here?:) |
|
Usually, you can take a look at the release note and mention a few notable bug lists from the release note. |
|
@dongjoon-hyun Thanks for your help！ |
|
It's nothing. Since you are one of the active contributor, I hope you can do more in the community. |
dongjoon-hyun
approved these changes
Feb 1, 2020
There was a problem hiding this comment.
+1, LGTM. Thank you, @beliefer .
The checkstyle is already passed. Merged to master.
|
@dongjoon-hyun Thanks for your help！I got it |
|
Test build #117710 has finished for PR 27426 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I found checkstyle have a new release https://checkstyle.org/releasenotes.html#Release_8.29
Bumps checkstyle from 8.25 to 8.29.
Why are the changes needed?
I have bump checkstyle from 8.25 to 8.29 on my fork branch and test to build.
It's OK
8.29 added some new features：
New Check: AvoidNoArgumentSuperConstructorCall.
New Check NoEnumTrailingComma.
ENUM_DEF token support in RightCurlyCheck.
FallThrough module does not support the spelling "fall-through" by default.
8.29 fix some bugs:
Java 8 Grammar: annotations on varargs parameters.
Sonar violation: Disable XML external entity (XXE) processing.
Disable instantiation of modules with private ctor.
Sonar violation: "ThreadLocal" variables should be cleaned up when no longer used.
Indentation incorrect level for chained method with bracket on new line.
InvalidJavadocPosition: false positive when comment is between javadoc and package.
Does this PR introduce any user-facing change?
No
How was this patch tested?
No UT