[3.0][SQL] Revert SPARK-32018 #29450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengliangwang
requested review from
cloud-fan,
dongjoon-hyun,
maropu and
viirya
|
Test build #127501 has finished for PR 29450 at commit
|
|
retest this please |
|
+1 to revert to unblock 3.0.1, also see my comment in #29448 (comment) |
|
Test build #127504 has finished for PR 29450 at commit
|
|
I'm merging it first as it's safer to revert and keep the behavior the same as before. We can re-try to fix it if we have better ideas. |
cloud-fan
pushed a commit
that referenced
this pull request
Aug 17, 2020
### What changes were proposed in this pull request? Revert SPARK-32018 related changes in branch 3.0: #29125 and #29404 ### Why are the changes needed? #29404 is made to fix correctness regression introduced by #29125. However, the behavior of decimal overflow is strange in non-ansi mode: 1. from 3.0.0 to 3.0.1: decimal overflow will throw exceptions instead of returning null on decimal overflow 2. from 3.0.1 to 3.1.0: decimal overflow will return null instead of throwing exceptions. So, this PR proposes to revert both #29404 and #29125. So that Spark will return null on decimal overflow in Spark 3.0.0 and Spark 3.0.1. ### Does this PR introduce _any_ user-facing change? Yes, Spark will return null on decimal overflow in Spark 3.0.1. ### How was this patch tested? Unit tests Closes #29450 from gengliangwang/revertDecimalOverflow. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
|
+1 for the reasoning. Thank you for the decision, @cloud-fan . |
|
looks good. |
|
Is it worth describing the current behaviour #29448 (comment) as a known issue in the v3.0.1 release note? |
|
@maropu This is a long-standing issue in Spark. I think we can mention the latest behavior in the migration guide and release note of 3.1.0. |
gengliangwang
added a commit
that referenced
this pull request
Aug 19, 2020
…erflow in sum aggregation ### What changes were proposed in this pull request? Add migration guide for decimal value overflow behavior in sum aggregation, introduced in #29026 ### Why are the changes needed? Add migration guide for the behavior changes from 3.0 to 3.1. See also: #29450 (comment) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Build docs and preview:  Closes #29458 from gengliangwang/migrationGuideDecimalOverflow. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Revert SPARK-32018 related changes in branch 3.0: #29125 and #29404
Why are the changes needed?
#29404 is made to fix correctness regression introduced by #29125. However, the behavior of decimal overflow is strange in non-ansi mode:
So, this PR proposes to revert both #29404 and #29125. So that Spark will return null on decimal overflow in Spark 3.0.0 and Spark 3.0.1.
Does this PR introduce any user-facing change?
Yes, Spark will return null on decimal overflow in Spark 3.0.1.
How was this patch tested?
Unit tests