Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-32608][SQL][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value #29520

Closed
wants to merge 1 commit into from

Conversation

AngersZhuuuu
Copy link
Contributor

What changes were proposed in this pull request?

As mentioned in #29428 (comment) by @viirya ,
fix bug in UT, since in script transformation no-serde mode, output of decimal is same in both hive-1.2/hive-2.3

Why are the changes needed?

FIX UT

Does this PR introduce any user-facing change?

NO

How was this patch tested?

EXISTED UT

@AngersZhuuuu
Copy link
Contributor Author

AngersZhuuuu commented Aug 23, 2020

cc @maropu @viirya

@viirya
Copy link
Member

viirya commented Aug 23, 2020

After #29519 is merged, we can trigger hive-1.2 profile test for this.

@SparkQA
Copy link

SparkQA commented Aug 23, 2020

Test build #127800 has finished for PR 29520 at commit 4920376.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya viirya changed the title [SPARK-32608][SQL][FOLLOW-UP] Script Transform ROW FORMAT DELIMIT value should format value [SPARK-32608][SQL][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value Aug 23, 2020
@viirya
Copy link
Member

viirya commented Aug 23, 2020

retest this please

@viirya
Copy link
Member

viirya commented Aug 23, 2020

Looks ok pending test.

@SparkQA
Copy link

SparkQA commented Aug 23, 2020

Test build #127806 has finished for PR 29520 at commit 4920376.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AngersZhuuuu
Copy link
Contributor Author

@viirya Seems this ut failed because of your pr?
#29520 (comment)

@viirya
Copy link
Member

viirya commented Aug 23, 2020

@viirya Seems this ut failed because of your pr?
#29520 (comment)

No, please see https://issues.apache.org/jira/browse/SPARK-32689. There are few test failed in branch-3.0 and master under hive-1.2 profile.

ScriptTransformationSuite is caused by your PR. Others are not sure from which PRs.

@viirya
Copy link
Member

viirya commented Aug 23, 2020

Jenkins shows this solved ScriptTransformationSuite error. Other two are known failure in hive-1.2 profile now. I'm going to merge this first. cc @dongjoon-hyun @maropu @HyukjinKwon

@viirya viirya closed this in 9808c15 Aug 23, 2020
@viirya
Copy link
Member

viirya commented Aug 23, 2020

Thanks @AngersZhuuuu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants