Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-34211][SQL][TESTS] Benchmark TPC-DS with 1GB scale factor #31303

Closed
wants to merge 3 commits into from
Closed

[SPARK-34211][SQL][TESTS] Benchmark TPC-DS with 1GB scale factor #31303

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e09b831
Benchmark TPC-DS with 1GB scale factor
wangyum Jan 23, 2021
e8faad3
Benchmark TPC-DS with 1GB scale factor
wangyum Jan 23, 2021
9da5102
fix
wangyum Jan 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions .github/workflows/build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,3 +430,38 @@ jobs:
- name: Build with SBT
run: |
./build/sbt -Pyarn -Pmesos -Pkubernetes -Phive -Phive-thriftserver -Phadoop-cloud -Pkinesis-asl -Phadoop-2.7 compile test:compile

tpcds1g:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no big deal but I would name it tpcds-1g

name: Benchmark TPC-DS with 1GB scale factor
runs-on: ubuntu-20.04
continue-on-error: true
steps:
- name: Checkout Spark repository
uses: actions/checkout@v2
- name: Checkout tpcds-kit repository
uses: actions/checkout@v2
with:
repository: databricks/tpcds-kit
path: ./tpcds-kit
- name: Checkout spark-sql-perf repository
uses: actions/checkout@v2
with:
repository: wangyum/spark-sql-perf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe what these repos do in the PR description? Also what does this fork do? Looks like only diff is wangyum/spark-sql-perf@abf08eb. Can you just use the original repo, and keep the data generate Scala file somewhere in Spark?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Original repo need a class: databricks/spark-sql-perf#196

path: ./spark-sql-perf
- name: Install Java 8
uses: actions/setup-java@v1
with:
java-version: 8
- name: Build tpcds-kit
run: cd tpcds-kit/tools && make OS=LINUX
- name: Gen TPCDS Data
run: cd spark-sql-perf && build/sbt "test:runMain com.databricks.spark.sql.GenTPCDSData `pwd`/../tpcds-kit/tools 1 `pwd`/../tpcds1g parquet"
- name: Run TPCDSQueryBenchmark
run: |
SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "sql/test:runMain org.apache.spark.sql.execution.benchmark.TPCDSQueryBenchmark --data-location `pwd`/tpcds1g --cbo"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we enable CBO by default? I think we should run it with the default conf.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we keep the cache of Coursier in SBT?

- name: Upload benchmark result to report
if: always()
uses: actions/upload-artifact@v2
with:
name: TPC-DS 1GB benchmark result
path: "sql/core/benchmarks/TPCDSQueryBenchmark-results.txt"