-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-34869][K8S][TEST] Extend "EXTRA LOGS FOR THE FAILED TEST" section of k8s integration test log with the describe pods output #31962
Conversation
Test build #136529 has finished for PR 31962 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works and helps debugging the failure, by all means get this in
Kubernetes integration test starting |
Kubernetes integration test status failure |
This is different error:
@srowen @shaneknapp do you know how Minikube runs are isolated on Jenkins? |
(No idea about any of that here, sorry) |
No problem, let's hope the next error will be the one we look for. |
jenkins retest this please |
Test build #136536 has finished for PR 31962 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
|
@srowen looking the events this must be a clue
|
Although I think the image should not be pulled from
@shaneknapp do you have any idea? Moreover this warning is also interesting: But I have to go now (it is 22:15 here) still I hope these events helps a bit. |
...ation-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
Outdated
Show resolved
Hide resolved
Thank you for pining me, @attilapiros . I agree with your analysis for the AS-IS Jenkins failure. Apparently, Amplab Jenkins seems to have a setup issue still. FYI, I have a personal downstream Jenkins machine dedicated to run K8s integration test for all Apache branches (master/3.1/3.0/2.4). I usually keep them up-to-date. Currently, Minikube 1.18.1 and K8s 1.20.2. They never fails for last 7 days in all branches. |
...s/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/minikube/Minikube.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. +1 for the idea.
- I added one minor editorial comment.
- After [SPARK-34869][K8S][TEST] Extend "EXTRA LOGS FOR THE FAILED TEST" section of k8s integration test log with the describe pods output #31962 (comment) is finished, I'll revisit this PR.
Test build #136552 has finished for PR 31962 at commit
|
Thanks @dongjoon-hyun . I also thought about checking the Minikube's bug/issue database for this v1.7.3 version but as you mentioned this is very likely a Minikube bug and the migration is already planned to the Minikube 1.18.1 via SPARK-34738 I think we have to wait until it is finished. |
I quickly went through the issues for this version: https://github.com/kubernetes/minikube/issues?page=3&q=is%3Aissue+v1.7.3. |
Kubernetes integration test starting |
Kubernetes integration test status failure |
|
jenkins retest this please |
Test build #136588 has finished for PR 31962 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for update, @attilapiros .
I've observed that the Amblab Jenkins hit out of disk issues in this year. There is no workaround in that case. This PR itself is meaningful.
Merged to master. |
Thanks @dongjoon-hyun ! |
What changes were proposed in this pull request?
Extending "EXTRA LOGS FOR THE FAILED TEST" section of k8s integration test log with
kubectl describe pods
output for the failed test.Why are the changes needed?
PR builds frequently fails as the k8s integration tests are very flaky now in Amplab Jenkins environment.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Locally by making temporary one of the test fail. The output is: