Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-34969][SPARK-34906][SQL] Followup for Refactor TreeNode's children handling methods into specialized traits #32065

Closed
wants to merge 10 commits into from

Conversation

dbaliafroozeh
Copy link
Contributor

@dbaliafroozeh dbaliafroozeh commented Apr 6, 2021

What changes were proposed in this pull request?

This is a followup for #31932.
In this PR we:

  • Introduce the QuaternaryLike trait for node types with 4 children.
  • Specialize more node types
  • Fix a number of style errors that were introduced in the original PR.

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

This is a refactoring, passes existing tests.

@dbaliafroozeh dbaliafroozeh changed the title [SPARK-34969] [SPARK-34969] Followup for SPARK-34906 Apr 6, 2021
@dbaliafroozeh dbaliafroozeh changed the title [SPARK-34969] Followup for SPARK-34906 [SPARK-34969] Followup for Refactor TreeNode's children handling methods into specialized traits (SPARK-34906) Apr 6, 2021
@SparkQA
Copy link

SparkQA commented Apr 6, 2021

Test build #136949 has finished for PR 32065 at commit f404246.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 6, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41525/

@SparkQA
Copy link

SparkQA commented Apr 6, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41525/

@SparkQA
Copy link

SparkQA commented Apr 6, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41528/

@SparkQA
Copy link

SparkQA commented Apr 6, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41528/

@SparkQA
Copy link

SparkQA commented Apr 6, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41536/

@SparkQA
Copy link

SparkQA commented Apr 6, 2021

Test build #136952 has finished for PR 32065 at commit 8bf4e1e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 6, 2021

Test build #136959 has finished for PR 32065 at commit 9f38813.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • trait SimpleHigherOrderFunction extends HigherOrderFunction with BinaryLike[Expression]

Copy link
Contributor

@hvanhovell hvanhovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maropu maropu changed the title [SPARK-34969] Followup for Refactor TreeNode's children handling methods into specialized traits (SPARK-34906) [SPARK-34969][SPARK-34906][SQL] Followup for Refactor TreeNode's children handling methods into specialized traits Apr 6, 2021
@hvanhovell hvanhovell closed this in 06c09a7 Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants