Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35031][PYTHON] Port Koalas operations on different frames tests into PySpark #32133

Closed

Conversation

xinrong-meng
Copy link
Member

@xinrong-meng xinrong-meng commented Apr 12, 2021

What changes were proposed in this pull request?

Now that we merged the Koalas main code into the PySpark code base (#32036), we should port the Koalas operations on different frames unit tests to PySpark.

Why are the changes needed?

Currently, the pandas-on-Spark modules are not tested fully. We should enable the operations on different frames unit tests.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Enable operations on different frames unit tests.

Keyword:SPARK-34849

@SparkQA
Copy link

SparkQA commented Apr 12, 2021

Test build #137240 has finished for PR 32133 at commit 34b8273.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@xinrong-meng xinrong-meng changed the title [WIP][SPARK-35031][PYTHON] Port Koalas operations on different DataFrames tests into PySpark [WIP][SPARK-35031][PYTHON] Port Koalas operations on different frames tests into PySpark Apr 12, 2021
@SparkQA
Copy link

SparkQA commented Apr 12, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41820/

@SparkQA
Copy link

SparkQA commented Apr 12, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41820/

@SparkQA
Copy link

SparkQA commented Apr 12, 2021

Test build #137244 has finished for PR 32133 at commit be499d5.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 12, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41824/

@SparkQA
Copy link

SparkQA commented Apr 12, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41824/

@SparkQA
Copy link

SparkQA commented Apr 12, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41827/

@SparkQA
Copy link

SparkQA commented Apr 12, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41827/

Copy link
Member

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending tests.

@SparkQA
Copy link

SparkQA commented Apr 13, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41834/

@SparkQA
Copy link

SparkQA commented Apr 13, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41834/

@SparkQA
Copy link

SparkQA commented Apr 13, 2021

Test build #137247 has finished for PR 32133 at commit c6c07a2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@xinrong-meng xinrong-meng changed the title [WIP][SPARK-35031][PYTHON] Port Koalas operations on different frames tests into PySpark [SPARK-35031][PYTHON] Port Koalas operations on different frames tests into PySpark Apr 13, 2021
@xinrong-meng xinrong-meng marked this pull request as ready for review April 13, 2021 02:10
@xinrong-meng
Copy link
Member Author

CC @HyukjinKwon @itholic

@HyukjinKwon
Copy link
Member

Merged to master.

@itholic
Copy link
Contributor

itholic commented Apr 13, 2021

Nice

@SparkQA
Copy link

SparkQA commented Apr 13, 2021

Test build #137255 has finished for PR 32133 at commit d0ea72a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants