Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35120][INFRA][FOLLOW-UP] Try catch an error to show the correct guidance #32258

Closed
wants to merge 1 commit into from

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Apr 20, 2021

What changes were proposed in this pull request?

This PR proposes to handle 404 not found, see https://github.com/apache/spark/pull/32255/checks?check_run_id=2390446579 as an example.

If a fork does not have any previous workflow runs, it seems throwing 404 error instead of empty runs.

Why are the changes needed?

To show the correct guidance to contributors.

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

Manually tested at HyukjinKwon#48. See https://github.com/HyukjinKwon/spark/runs/2391469416 as an example.

@HyukjinKwon
Copy link
Member Author

@dongjoon-hyun would you mind taking a quick look please?

@github-actions github-actions bot added the INFRA label Apr 20, 2021
@HyukjinKwon HyukjinKwon changed the title [SPARK-35120][INFRA][FOLLOW-UP] Try catch 404 error to show the correct guidance [SPARK-35120][INFRA][FOLLOW-UP] Try catch an error to show the correct guidance Apr 20, 2021
@SparkQA
Copy link

SparkQA commented Apr 20, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42214/

@SparkQA
Copy link

SparkQA commented Apr 20, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42214/

@SparkQA
Copy link

SparkQA commented Apr 20, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42218/

@SparkQA
Copy link

SparkQA commented Apr 20, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42218/

@SparkQA
Copy link

SparkQA commented Apr 20, 2021

Test build #137687 has finished for PR 32258 at commit 8866dc0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 20, 2021

Test build #137691 has finished for PR 32258 at commit ff8985c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

cc @gengliangwang too

Copy link
Member

@gengliangwang gengliangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gengliangwang
Copy link
Member

Thanks, merging to master

@HyukjinKwon
Copy link
Member Author

Thanks @gengliangwang !

@HyukjinKwon HyukjinKwon deleted the SPARK-35120-followup branch January 4, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants