Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-35111][SQL] Support Cast string to year-month interval #32266
[SPARK-35111][SQL] Support Cast string to year-month interval #32266
Changes from all commits
9546a0f
691c1f4
f5b02ee
15424a7
879817b
62d175b
2c75bba
5b134fa
6d14414
d19bbc8
ff904a1
d0e30e4
3b84baa
b05f7e6
25c08e0
f636d41
ce69004
092d01a
f088f64
80499b8
ca19c09
3df92b6
3adde87
0f82987
2c8785b
253c70e
9c70b88
5ca83ab
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add round trip tests: string -> year-month interval -> string, and year-month interval -> string -> year-month interval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you test corner cases when arithmetic overflow happens. Also test upper and lower cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current test is not correct according to #32281, will update after #32281 merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, check the input in lower case. For example: