[SPARK-34692][SQL][FOLLOWUP] Add INSET to ReplaceNullWithFalseInPredicate's pattern #32278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Thanks for catching this ! Seems we need to rebase the code to trigger test with the new added transform framework otherwise it might make the master branch down. |
5 tasks
dongjoon-hyun
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
+1, LGTM. All test passed except linter job. Linter jobs failure is recovered in master by another PR.
Merged to master. Thank you, @viirya and all.
|
Thank you @dongjoon-hyun @ulysses-you |
|
Test build #137755 has finished for PR 32278 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The test added by #31797 has the failure. This is a followup to fix it.
Why are the changes needed?
Due to #32157, the rule
ReplaceNullWithFalseInPredicatewill check tree pattern before actually doing transformation. AsnullinINSETis notNULL_LITERALpattern, we miss it and fail the newly addednot inset ...check inreplaceNullWithFalse.Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing unit tests.