Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35021][SQL] Group exception messages in connector/catalog #32377

Closed
wants to merge 6 commits into from

Conversation

beliefer
Copy link
Contributor

What changes were proposed in this pull request?

This PR group exception messages in sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog.

Why are the changes needed?

It will largely help with standardization of error messages and its maintenance.

Does this PR introduce any user-facing change?

No. Error messages remain unchanged.

How was this patch tested?

No new tests - pass all original tests to make sure it doesn't break any existing behavior.

@github-actions github-actions bot added the SQL label Apr 28, 2021
@SparkQA
Copy link

SparkQA commented Apr 28, 2021

Test build #138035 has finished for PR 32377 at commit b75afcc.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 28, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42554/

@SparkQA
Copy link

SparkQA commented Apr 28, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42556/

@SparkQA
Copy link

SparkQA commented Apr 28, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42556/

@SparkQA
Copy link

SparkQA commented Apr 28, 2021

Test build #138037 has finished for PR 32377 at commit cabb9c8.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@beliefer
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Apr 29, 2021

Test build #138057 has finished for PR 32377 at commit cabb9c8.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 29, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42576/

@SparkQA
Copy link

SparkQA commented Apr 29, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42584/

@SparkQA
Copy link

SparkQA commented Apr 29, 2021

Test build #138065 has finished for PR 32377 at commit b0806df.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@beliefer
Copy link
Contributor Author

ping @allisonwang-db

new AnalysisException(s"Cannot use catalog ${plugin.name}: $msg")
}

def invalidIdentifierAsItHasMoreThanTwoNamePartsError(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about identifierHavingMoreThanTwoNamePartsError

new AnalysisException(s"Cannot create tables with ${NullType.simpleString} type.")
}

def functionUnsupportedInV1CatalogError(): Throwable = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionUnsupportedInV2CatalogError

@SparkQA
Copy link

SparkQA commented May 6, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42712/

@SparkQA
Copy link

SparkQA commented May 6, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42712/

@SparkQA
Copy link

SparkQA commented May 6, 2021

Test build #138191 has finished for PR 32377 at commit 5106ed0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@beliefer
Copy link
Contributor Author

beliefer commented May 6, 2021

ping @allisonwang-db

@beliefer
Copy link
Contributor Author

beliefer commented May 7, 2021

cc @cloud-fan

@cloud-fan
Copy link
Contributor

@beliefer can you fix the conflicts? thanks!

@beliefer
Copy link
Contributor Author

beliefer commented May 7, 2021

@beliefer can you fix the conflicts? thanks!

OK

@SparkQA
Copy link

SparkQA commented May 7, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42767/

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in d3b92ee May 7, 2021
@SparkQA
Copy link

SparkQA commented May 7, 2021

Test build #138245 has finished for PR 32377 at commit 4db4250.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • trait ExtractValue extends Expression
  • case class AddJarsCommand(paths: Seq[String]) extends LeafRunnableCommand
  • case class AddFilesCommand(paths: Seq[String]) extends LeafRunnableCommand
  • case class AddArchivesCommand(paths: Seq[String]) extends LeafRunnableCommand

@beliefer
Copy link
Contributor Author

beliefer commented May 7, 2021

@allisonwang-db Thank you for review. @cloud-fan Thank you too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants